Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 16314002: Revert "Clean up the initializer mess in Document." (Closed)

Created:
7 years, 6 months ago by falken
Modified:
7 years, 6 months ago
Reviewers:
dcheng
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert "Clean up the initializer mess in Document." This reverts commit e54ba8d3b62b0245ecdf2f3ec11cd33b4035a4d7. Reverting because it caused assertions failures in svg/batik/text, for example: svg/batik/text/textEffect2.svg crashed, (stderr lines): ASSERTION FAILED: equalIgnoringFragmentIdentifier(url, externalDocument->url()) ../../third_party/WebKit/Source/core/svg/SVGURIReference.cpp(92) : static WebCore::Element* WebCore::SVGURIReference::targetElementFromIRIString(const WTF::String&, WebCore::Document*, WTF::String*, WebCore::Document*) BUG= TBR=dcheng@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -32 lines) Patch
M Source/core/dom/Document.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +42 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
7 years, 6 months ago (2013-06-03 02:26:08 UTC) #1
falken
Committed patchset #1 manually as r151625 (presubmit successful).
7 years, 6 months ago (2013-06-03 02:27:36 UTC) #2
falken
7 years, 6 months ago (2013-06-03 02:29:07 UTC) #3
Message was sent while issue was closed.
On 2013/06/03 02:27:36, falken wrote:
> Committed patchset #1 manually as r151625 (presubmit successful).

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT -
chromium.org&tests=css3/filters/composited-during-animation-layertree.html,fast/dom/TreeWalker/filter-throw.html,http/tests/misc/acid3.html,inspector/timeline/timeline-decode-resize.html,svg/W3C-SVG-1.1/struct-use-05-b.svg,svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg,svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg,svg/batik/filters/feTile.svg,svg/batik/filters/filterRegions.svg,svg/batik/masking/maskRegions.svg,svg/batik/paints/gradientLimit.svg,svg/batik/paints/patternPreserveAspectRatioA.svg,svg/batik/paints/patternRegionA.svg,svg/batik/paints/patternRegions-positioned-objects.svg,svg/batik/paints/patternRegions.svg,svg/batik/text/longTextOnPath.svg,svg/batik/text/smallFonts.svg,svg/batik/text/textAnchor.svg,svg/batik/text/textDecoration.svg,svg/batik/text/textEffect.svg,svg/batik/text/textEffect2.svg,svg/batik/text/textEffect3.svg,svg/batik/text/textFeatures.svg,svg/batik/text/textLayout.svg,svg/batik/text/textLayout2.svg,svg/batik/text/textLength.svg,svg/batik/text/textOnPath.svg,svg/batik/text/textOnPathSpaces.svg,svg/batik/text/textPosition.svg,svg/batik/text/textPosition2.svg,svg/batik/text/textProperties.svg,svg/batik/text/textProperties2.svg,svg/batik/text/textStyles.svg,svg/batik/text/verticalText.svg,svg/batik/text/verticalTextOnPath.svg,svg/custom/use-extern-href.svg,svg/custom/use-external-crash.svg,svg/custom/use-referencing-indirectly-itself.svg,svg/dynamic-updates/SVGUseElement-dom-href1-attr.html,svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html,svg/hixie/error/014.xml,svg/hixie/use/002.xml,traversal/exception-forwarding.html,fast/canvas/webgl/uninitialized-test.html,fast/js/regress/Int16Array-bubble-sort.html,virtual/gpu/compositedscrolling/overflow/automatically-opt-into-composited-scrolling.html,virtual/gpu/fast/canvas/webgl/uninitialized-test.html

Powered by Google App Engine
This is Rietveld 408576698