Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1631393002: NaCl cleanup: Remove some unused Gyp/GN library dependencies (Closed)

Created:
4 years, 11 months ago by Mark Seaborn
Modified:
4 years, 11 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Remove some unused Gyp/GN library dependencies This will allow removing simple_service from the NaCl side. BUG=302078 TEST=build Committed: https://crrev.com/df8e065bfbb01f977175e3596a274d3edfc392b4 Cr-Commit-Position: refs/heads/master@{#371633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M components/nacl/renderer/plugin/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/nacl/renderer/plugin/plugin.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631393002/1
4 years, 11 months ago (2016-01-26 20:10:50 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/13118)
4 years, 11 months ago (2016-01-26 20:38:01 UTC) #4
Mark Seaborn
4 years, 11 months ago (2016-01-26 22:32:54 UTC) #7
bbudge
lgtm
4 years, 11 months ago (2016-01-26 22:33:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631393002/1
4 years, 11 months ago (2016-01-26 23:08:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 23:30:13 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 23:31:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df8e065bfbb01f977175e3596a274d3edfc392b4
Cr-Commit-Position: refs/heads/master@{#371633}

Powered by Google App Engine
This is Rietveld 408576698