Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/ui/app_list/test/fake_profile_store.h

Issue 1631373003: Refactor ProfileInfoCache in c/b/ui/app_list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comments, add sorting of ProfileAttributesEntry Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/test/fake_profile_store.h
diff --git a/chrome/browser/ui/app_list/test/fake_profile_store.h b/chrome/browser/ui/app_list/test/fake_profile_store.h
index 2b2c586d51373bf1a41f3015b39999c50cf137a3..347baaab8d39ae4797c533d318017b536ba560b6 100644
--- a/chrome/browser/ui/app_list/test/fake_profile_store.h
+++ b/chrome/browser/ui/app_list/test/fake_profile_store.h
@@ -6,9 +6,11 @@
#define CHROME_BROWSER_UI_APP_LIST_TEST_FAKE_PROFILE_STORE_H_
#include <map>
+#include <string>
tapted 2016/01/31 23:04:37 nit: I think typically we say, if you need a type
lwchkg 2016/02/01 06:31:20 Thanks. Your point is really good! Anyway I added
#include "base/callback.h"
#include "base/observer_list.h"
+#include "chrome/browser/profiles/profile_attributes_storage.h"
#include "chrome/browser/ui/app_list/profile_store.h"
class PrefService;
@@ -23,7 +25,8 @@ class FakeProfileStore : public ProfileStore {
void RemoveProfile(Profile* profile);
// ProfileStore overrides.
- void AddProfileObserver(ProfileInfoCacheObserver* observer) override;
+ void AddProfileObserver(ProfileAttributesStorage::Observer* observer)
+ override;
void LoadProfileAsync(const base::FilePath& path,
base::Callback<void(Profile*)> callback) override;
Profile* GetProfileByPath(const base::FilePath& path) override;
@@ -38,7 +41,7 @@ class FakeProfileStore : public ProfileStore {
typedef std::map<base::FilePath, base::Callback<void(Profile*)> >
CallbacksByPath;
CallbacksByPath callbacks_;
- base::ObserverList<ProfileInfoCacheObserver> observer_list_;
+ base::ObserverList<ProfileAttributesStorage::Observer> observer_list_;
typedef std::map<base::FilePath, Profile*> ProfilesByPath;
ProfilesByPath loaded_profiles_;
};

Powered by Google App Engine
This is Rietveld 408576698