Refactor ProfileInfoCache in c/b/ui/app_list

chrome/browser/ui/app_list/app_list_service_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/app_list/app_list_service_mac.h"
 
 #include <ApplicationServices/ApplicationServices.h>
 #import <Cocoa/Cocoa.h>
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/lazy_instance.h"
 #include "base/memory/singleton.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/profiles/profile_info_cache.h"
+#include "chrome/browser/profiles/profile_attributes_entry.h"
+#include "chrome/browser/profiles/profile_attributes_storage.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/app_list/app_list_positioner.h"
 #include "chrome/browser/ui/app_list/app_list_service.h"
 #include "chrome/browser/ui/app_list/app_list_service_cocoa_mac.h"
 #include "chrome/browser/ui/app_list/app_list_service_impl.h"
 #include "chrome/browser/ui/app_list/app_list_util.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/browser/web_applications/web_app_mac.h"
@@ skipping 347 matching lines @@
   // launcher shim. The profile has not yet been loaded. To improve response
   // times, start animating an empty window which will be populated via
   // OnShimLaunch(). Note that if --silent-launch is not also passed, the window
   // will instead populate via StartupBrowserCreator::Launch(). Shim-initiated
   // launches will always have --silent-launch.
   if (base::CommandLine::ForCurrentProcess()->
       HasSwitch(switches::kShowAppList)) {
     // Do not show the launcher window when the profile is locked, or if it
     // can't be displayed unpopulated. In the latter case, the Show will occur
     // in OnShimLaunch() or AppListService::HandleLaunchCommandLine().
-    const ProfileInfoCache& profile_info_cache =
-        g_browser_process->profile_manager()->GetProfileInfoCache();
-    size_t profile_index = profile_info_cache.
-        GetIndexOfProfileWithPath(profile_path);
-    if (profile_index != std::string::npos &&
-        !profile_info_cache.ProfileIsSigninRequiredAtIndex(profile_index) &&
-        ReadyToShow())
+    ProfileAttributesEntry* entry = nullptr;
+    bool has_entry = g_browser_process->profile_manager()->
+        GetProfileAttributesStorage().
+        GetProfileAttributesWithPath(profile_path, &entry);
+    if (has_entry && entry->IsSigninRequired() && ReadyToShow())

[tapted, 2016/01/31 23:04:37]

drive-by: I think you're missing a `!` before entry->IsSigninRequired()

[lwchkg, 2016/02/01 06:31:20]

Thanks for spotting! I don't have a Mac myself, so it's very easy to make
mistakes!

Anyway I have a question: do you think that this type of error will be caught in
tests?

[tapted, 2016/02/02 00:20:55]

Not sure - this path is used to improve response times, rather than change
functional behaviour, so it's likely not tested.

       ShowWindowNearDock();
   }
 }
 
 void AppListServiceMac::DismissAppList() {
   if (!IsAppListVisible())
     return;
 
   NSWindow* app_list_window = GetNativeWindow();
   // If the app list is currently the main window, it will activate the next
@@ skipping 173 matching lines @@
 
 - (void)animationDidEnd:(NSAnimation*)animation {
   content::BrowserThread::PostTask(
       content::BrowserThread::UI,
       FROM_HERE,
       base::Bind(&AppListServiceMac::WindowAnimationDidEnd,
                  base::Unretained(GetActiveInstance())));
 }
 
 @end