chrome/browser/profiles/profile_attributes_storage_observer.h - Issue 1631373003: Refactor ProfileInfoCache in c/b/ui/app_list

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/profiles/profile_attributes_storage_observer.h

Issue 1631373003: Refactor ProfileInfoCache in c/b/ui/app_list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/profiles/profile_attributes_storage.h ('K') | « chrome/browser/profiles/profile_attributes_storage.h ('k') | chrome/browser/ui/app_list/app_list_service_impl.h » ('j') | chrome/browser/ui/app_list/app_list_view_delegate.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_OBSERVER_H_

	6 #define CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_OBSERVER_H_

	7

	8 #include "chrome/browser/profiles/profile_info_cache_observer.h"

	9

	10 using ProfileAttributesStorageObserver = ProfileInfoCacheObserver;
	lwchkg 2016/01/27 22:37:19 Name of new class: please comment as usual. Name of new class: please comment as usual. anthonyvd 2016/01/29 15:16:34 I would prefer not adding this file, include profi Show quoted text On 2016/01/27 22:37:19, lwchkg wrote: > Name of new class: please comment as usual. I would prefer not adding this file, include profile_info_cache_observer.h in profile_attributes_storage.h, and do using Observer = ProfileInfoCacheObserver; inside the ProfileAttributesStorage class declaration. Then when the PIC is removed, we can also fix the declaration of course. Most Observers are implemented as nested classes in the codebase at the moment, and it's almost never necessary to use the Observer without the Observee. lwchkg 2016/01/29 19:01:48 Acknowledged. Show quoted text On 2016/01/29 15:16:34, anthonyvd wrote: > On 2016/01/27 22:37:19, lwchkg wrote: > > Name of new class: please comment as usual. > > I would prefer not adding this file, include profile_info_cache_observer.h in > profile_attributes_storage.h, and do using Observer = ProfileInfoCacheObserver; > inside the ProfileAttributesStorage class declaration. Then when the PIC is > removed, we can also fix the declaration of course. > > Most Observers are implemented as nested classes in the codebase at the moment, > and it's almost never necessary to use the Observer without the Observee. Acknowledged.
	11

	12 #endif // CHROME_BROWSER_PROFILES_PROFILE_ATTRIBUTES_STORAGE_OBSERVER_H_

OLD	NEW