Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1631333002: [turbofan] Fix iteration order (Closed)

Created:
4 years, 10 months ago by sigurds
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve iteration order in escape object analysis BUG=v8:4586 LOG=n Committed: https://crrev.com/e41c62a8ffdab5d3e18f7dca7a616147cea8f289 Cr-Commit-Position: refs/heads/master@{#33542}

Patch Set 1 #

Patch Set 2 : Fix terrible terrible bug #

Patch Set 3 : Improve iteration order #

Patch Set 4 : Reactivate test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -125 lines) Patch
M src/compiler/escape-analysis.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/escape-analysis.cc View 1 2 66 chunks +61 lines, -119 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
sigurds
This CL should solve the problems with excessive runtime in test/mjsunit/regress/regress-1200351.js. PTAL
4 years, 10 months ago (2016-01-27 09:53:52 UTC) #2
Michael Starzinger
LGTM, can we change the mjsunit.status file to run the regress-1200351 test in all variants ...
4 years, 10 months ago (2016-01-27 09:59:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631333002/60001
4 years, 10 months ago (2016-01-27 10:29:26 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-01-27 11:05:28 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 11:06:01 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e41c62a8ffdab5d3e18f7dca7a616147cea8f289
Cr-Commit-Position: refs/heads/master@{#33542}

Powered by Google App Engine
This is Rietveld 408576698