Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1631313002: tools/battor_agent: Adds a tool to find connected BattOrs (Closed)

Created:
4 years, 10 months ago by charliea (OOO until 10-5)
Modified:
4 years, 10 months ago
Reviewers:
Zhen Wang, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/battor_agent: Adds a tool to find connected BattOrs This is a resubmission of https://codereview.chromium.org/1611533002/. That CL was reverted because it caused Android build bot failures. Since then, I submitted https://codereview.chromium.org/1611353003/, which prevents battor_agent from being built on Android (and Chromecast). This tool will also be used by the Chromium trace controller to find any connected BattOrs. TBR=zhenw@chromium.org,sky@chromium.org BUG=542837 Committed: https://crrev.com/5897360aaf5ee2ab3abafdfc96ca6b45b827c8d7 Cr-Commit-Position: refs/heads/master@{#371543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -4 lines) Patch
M tools/battor_agent/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/battor_agent/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/battor_agent/battor_agent.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/battor_agent/battor_agent_bin.cc View 4 chunks +20 lines, -4 lines 0 comments Download
A tools/battor_agent/battor_finder.h View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/battor_agent/battor_finder.cc View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631313002/1
4 years, 10 months ago (2016-01-26 17:20:09 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-26 18:09:58 UTC) #5
charliea (OOO until 10-5)
4 years, 10 months ago (2016-01-26 18:11:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631313002/1
4 years, 10 months ago (2016-01-26 18:12:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-26 18:18:53 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 18:19:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5897360aaf5ee2ab3abafdfc96ca6b45b827c8d7
Cr-Commit-Position: refs/heads/master@{#371543}

Powered by Google App Engine
This is Rietveld 408576698