[Mac] Remove some dead avatar menu code

[Mac] Remove some dead avatar menu code

This started out as the Mac counterpart to https://codereview.chromium.org/1614523002/
(removing old supervised user code) but got a bit larger :)

BUG=none

Committed: https://crrev.com/603282ea54976426ab32582e549a379833c5fb90
Cr-Commit-Position: refs/heads/master@{#371800}

[Marc Treib, 2016-01-26 18:32:26]

treib@chromium.org changed reviewers:
+ rsesek@chromium.org

[Marc Treib, 2016-01-26 18:32:26]

PTAL!

[Robert Sesek, 2016-01-26 18:33:23]

Description was changed from

==========
[Mac] Remove some dead avatar menu code

This started out as the Mac counterpart to
https://codereview.chromium.org/1614523002/ (removing old supervised user code)
but got a bit larger :)

BUG=none
==========

to

==========
[Mac] Remove some dead avatar menu code

This started out as the Mac counterpart to
https://codereview.chromium.org/1614523002/
(removing old supervised user code) but got a bit larger :)

BUG=none
==========

[Robert Sesek, 2016-01-26 18:37:56]

https://codereview.chromium.org/1631283002/diff/1/chrome/browser/ui/cocoa/pro...
File chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm (left):

https://codereview.chromium.org/1631283002/diff/1/chrome/browser/ui/cocoa/pro...
chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm:187: -
(void)updateAvatarButtonAndLayoutParent:(BOOL)layoutParent {
Can this be removed safely? AvatarBaseController implements this as NOTREACHED()
and it appears this can be called when ProfileInfoUpdateObserver receives a
callback.

[Marc Treib, 2016-01-27 14:06:54]

https://codereview.chromium.org/1631283002/diff/1/chrome/browser/ui/cocoa/pro...
File chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm (left):

https://codereview.chromium.org/1631283002/diff/1/chrome/browser/ui/cocoa/pro...
chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm:187: -
(void)updateAvatarButtonAndLayoutParent:(BOOL)layoutParent {
On 2016/01/26 18:37:56, Robert Sesek wrote:
> Can this be removed safely? AvatarBaseController implements this as
NOTREACHED()
> and it appears this can be called when ProfileInfoUpdateObserver receives a
> callback.

Good catch! I've added back an empty implementation. (The alternative would be
to remove the NOTREACHED() - which do you prefer?)

Really, there's no reason for this class to receive profile notifications at all
anymore. But that's for another CL...

[Robert Sesek, 2016-01-27 15:44:08]

I prefer nop'ing it out like you've done here. LGTM

[Marc Treib, 2016-01-27 15:44:35]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-01-27 15:44:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631283002/20001

[commit-bot: I haz the power, 2016-01-27 16:27:21]

Description was changed from

==========
[Mac] Remove some dead avatar menu code

This started out as the Mac counterpart to
https://codereview.chromium.org/1614523002/
(removing old supervised user code) but got a bit larger :)

BUG=none
==========

to

==========
[Mac] Remove some dead avatar menu code

This started out as the Mac counterpart to
https://codereview.chromium.org/1614523002/
(removing old supervised user code) but got a bit larger :)

BUG=none
==========

[commit-bot: I haz the power, 2016-01-27 16:27:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 16:28:13]

Description was changed from

==========
[Mac] Remove some dead avatar menu code

This started out as the Mac counterpart to
https://codereview.chromium.org/1614523002/
(removing old supervised user code) but got a bit larger :)

BUG=none
==========

to

==========
[Mac] Remove some dead avatar menu code

This started out as the Mac counterpart to
https://codereview.chromium.org/1614523002/
(removing old supervised user code) but got a bit larger :)

BUG=none

Committed: https://crrev.com/603282ea54976426ab32582e549a379833c5fb90
Cr-Commit-Position: refs/heads/master@{#371800}
==========

[commit-bot: I haz the power, 2016-01-27 16:28:14]

Patchset 2 (id:??) landed as
https://crrev.com/603282ea54976426ab32582e549a379833c5fb90
Cr-Commit-Position: refs/heads/master@{#371800}