PlzNavigate: fix expectation in NavigationControllerBrowserTest

PlzNavigate: fix expectation in NavigationControllerBrowserTest

This fixes one expectation in
NavigationControllerBrowserTest.FrameNavigationEntry_FrameUniqueName following
PlzNavigate switch to frame history entries.

BUG=575210
Committed: https://crrev.com/dd8101d22038e533c44d64ef47aafbe303108ed0
Cr-Commit-Position: refs/heads/master@{#372104}

[clamy, 2016-01-26 15:43:49]

Description was changed from

==========
PlzNavigate: fix expectation in NavigationControllerBrowserTest

This fixes one expectation in
NavigationControllerBrowserTest.FrameNavigationEntry_FrameUniqueName following
PlzNavigate switch to frame history entries.

BUG=575210
==========

to

==========
PlzNavigate: fix expectation in NavigationControllerBrowserTest

This fixes one expectation in
NavigationControllerBrowserTest.FrameNavigationEntry_FrameUniqueName following
PlzNavigate switch to frame history entries.

BUG=575210
==========

[clamy, 2016-01-26 15:43:49]

clamy@chromium.org changed reviewers:
+ creis@chromium.org

[clamy, 2016-01-26 15:44:02]

@creis: PTAL

[Charlie Reis, 2016-01-26 17:21:47]

[+site-isolation-reviews]

Sorry about that!  I shouldn't have conflated the two modes.  Seems generally
right but we shouldn't make the change specific to PlzNavigate.

https://codereview.chromium.org/1631273003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/1631273003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:2609: //
PlzNavigate: when ran just with PlzNavigate enabled, and not in
nit: s/ran/run/, drop comma.

https://codereview.chromium.org/1631273003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:2613:
EXPECT_TRUE(IsBrowserSideNavigationEnabled());
We shouldn't assume PlzNavigate is the only way for this to happen.  It'll fail
the same way if you run it with --isolate-sites-for-testing="".  Making this
check about AreCrossProcessFramesPossible should be sufficient.

(We should update the comment as well.)

[clamy, 2016-01-27 10:50:42]

Thanks!

https://codereview.chromium.org/1631273003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/1631273003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:2609: //
PlzNavigate: when ran just with PlzNavigate enabled, and not in
On 2016/01/26 17:21:46, Charlie Reis wrote:
> nit: s/ran/run/, drop comma.

Done.

https://codereview.chromium.org/1631273003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:2613:
EXPECT_TRUE(IsBrowserSideNavigationEnabled());
On 2016/01/26 17:21:46, Charlie Reis wrote:
> We shouldn't assume PlzNavigate is the only way for this to happen.  It'll
fail
> the same way if you run it with --isolate-sites-for-testing="".  Making this
> check about AreCrossProcessFramesPossible should be sufficient.
> 
> (We should update the comment as well.)

Done.

[Charlie Reis, 2016-01-27 17:24:17]

Thanks!  LGTM with nit.

https://codereview.chromium.org/1631273003/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/1631273003/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:28:
#include "content/public/common/browser_side_navigation_policy.h"
nit: No longer needed.

[clamy, 2016-01-28 13:11:16]

Thanks!

https://codereview.chromium.org/1631273003/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/1631273003/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:28:
#include "content/public/common/browser_side_navigation_policy.h"
On 2016/01/27 17:24:17, Charlie Reis wrote:
> nit: No longer needed.

Done.

[clamy, 2016-01-28 13:11:27]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-01-28 13:11:27]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1631273003/#ps40001
(title: "Removed unused include")

[commit-bot: I haz the power, 2016-01-28 13:11:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631273003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631273003/40001

[commit-bot: I haz the power, 2016-01-28 15:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 15:49:15]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[clamy, 2016-01-28 15:51:43]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2016-01-28 15:52:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631273003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631273003/40001

[commit-bot: I haz the power, 2016-01-28 16:40:01]

Description was changed from

==========
PlzNavigate: fix expectation in NavigationControllerBrowserTest

This fixes one expectation in
NavigationControllerBrowserTest.FrameNavigationEntry_FrameUniqueName following
PlzNavigate switch to frame history entries.

BUG=575210
==========

to

==========
PlzNavigate: fix expectation in NavigationControllerBrowserTest

This fixes one expectation in
NavigationControllerBrowserTest.FrameNavigationEntry_FrameUniqueName following
PlzNavigate switch to frame history entries.

BUG=575210
==========

[commit-bot: I haz the power, 2016-01-28 16:40:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-28 16:41:41]

Description was changed from

==========
PlzNavigate: fix expectation in NavigationControllerBrowserTest

This fixes one expectation in
NavigationControllerBrowserTest.FrameNavigationEntry_FrameUniqueName following
PlzNavigate switch to frame history entries.

BUG=575210
==========

to

==========
PlzNavigate: fix expectation in NavigationControllerBrowserTest

This fixes one expectation in
NavigationControllerBrowserTest.FrameNavigationEntry_FrameUniqueName following
PlzNavigate switch to frame history entries.

BUG=575210

Committed: https://crrev.com/dd8101d22038e533c44d64ef47aafbe303108ed0
Cr-Commit-Position: refs/heads/master@{#372104}
==========

[commit-bot: I haz the power, 2016-01-28 16:41:42]

Patchset 3 (id:??) landed as
https://crrev.com/dd8101d22038e533c44d64ef47aafbe303108ed0
Cr-Commit-Position: refs/heads/master@{#372104}