Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1631263002: Download unittest package from cloud storage. (Closed)

Created:
4 years, 11 months ago by Bill Hesse
Modified:
4 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Download unittest package from cloud storage. The deprecated unittest package is version 0.11.6 of the test package. Checking it out via git, alongside test, causes a git-cache locking conflict. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/47df139ed3c1c368d9e443b42901e082832d228b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M DEPS View 3 chunks +16 lines, -3 lines 0 comments Download
M third_party/.gitignore View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/pkg/unittest.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 11 months ago (2016-01-26 15:16:20 UTC) #2
Søren Gjesse
lgtm
4 years, 11 months ago (2016-01-26 15:39:26 UTC) #3
Bill Hesse
4 years, 11 months ago (2016-01-26 16:07:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47df139ed3c1c368d9e443b42901e082832d228b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698