Filter goog constraints in tabCapture API.

Filter goog constraints in tabCapture API.

A recent commit broke the ability for the Google Cast and Media Router
extensions to start tab capture for mirroring.  The root cause was due
to the new behavior where the presence of deprecated constraints now
causes the getUserMedia() API to error-out (instead of silently ignoring
the constraints).

The short-term fix here is to simply filter out all goog* constraints
since they have no effect on tab capture.

BUG=579729
TBR=hta@chromium.org

Committed: https://crrev.com/5af0ca15f399f6cfa688441be25a86b2d6e62362
Cr-Commit-Position: refs/heads/master@{#371647}

[miu, 2016-01-26 22:56:24]

miu@chromium.org changed reviewers:
+ hta@chromium.org

[miu, 2016-01-26 22:56:42]

Description was changed from

==========
Filter goog constraints in tabCapture API.

A recent commit broke the ability for the Google Cast and Media Router
extensions to start tab capture for mirroring.  The root cause was due
to the new behavior where the presence of deprecated constraints now
causes the getUserMedia() API to error-out (instead of silently ignoring
the constraints).

The short-term fix here is to simply filter out all goog* constraints
since they have no effect on tab capture.

BUG=579729
==========

to

==========
Filter goog constraints in tabCapture API.

A recent commit broke the ability for the Google Cast and Media Router
extensions to start tab capture for mirroring.  The root cause was due
to the new behavior where the presence of deprecated constraints now
causes the getUserMedia() API to error-out (instead of silently ignoring
the constraints).

The short-term fix here is to simply filter out all goog* constraints
since they have no effect on tab capture.

BUG=579729
TBR=hta@chromium.org
==========

[miu, 2016-01-26 22:57:04]

hta: PTAL

BTW--I am submitting TBR because it's absolutely critical we get this in before
the next dev channel cut.

[miu, 2016-01-26 22:57:09]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2016-01-26 22:57:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631243003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631243003/1

[hta - Chromium, 2016-01-26 23:10:42]

Before I start analyzing the CL - can you point me to the bug and the diagnosis?

I've been trying quite hard to avoid changing existing behavior (to the point
where we support > 50 different constraint names) - changing the behavior of
other constraints because of a change I did to constraint behavior seems like
the wrong thing to do.

[commit-bot: I haz the power, 2016-01-27 00:08:54]

Description was changed from

==========
Filter goog constraints in tabCapture API.

A recent commit broke the ability for the Google Cast and Media Router
extensions to start tab capture for mirroring.  The root cause was due
to the new behavior where the presence of deprecated constraints now
causes the getUserMedia() API to error-out (instead of silently ignoring
the constraints).

The short-term fix here is to simply filter out all goog* constraints
since they have no effect on tab capture.

BUG=579729
TBR=hta@chromium.org
==========

to

==========
Filter goog constraints in tabCapture API.

A recent commit broke the ability for the Google Cast and Media Router
extensions to start tab capture for mirroring.  The root cause was due
to the new behavior where the presence of deprecated constraints now
causes the getUserMedia() API to error-out (instead of silently ignoring
the constraints).

The short-term fix here is to simply filter out all goog* constraints
since they have no effect on tab capture.

BUG=579729
TBR=hta@chromium.org
==========

[commit-bot: I haz the power, 2016-01-27 00:08:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 00:09:45]

Description was changed from

==========
Filter goog constraints in tabCapture API.

A recent commit broke the ability for the Google Cast and Media Router
extensions to start tab capture for mirroring.  The root cause was due
to the new behavior where the presence of deprecated constraints now
causes the getUserMedia() API to error-out (instead of silently ignoring
the constraints).

The short-term fix here is to simply filter out all goog* constraints
since they have no effect on tab capture.

BUG=579729
TBR=hta@chromium.org
==========

to

==========
Filter goog constraints in tabCapture API.

A recent commit broke the ability for the Google Cast and Media Router
extensions to start tab capture for mirroring.  The root cause was due
to the new behavior where the presence of deprecated constraints now
causes the getUserMedia() API to error-out (instead of silently ignoring
the constraints).

The short-term fix here is to simply filter out all goog* constraints
since they have no effect on tab capture.

BUG=579729
TBR=hta@chromium.org

Committed: https://crrev.com/5af0ca15f399f6cfa688441be25a86b2d6e62362
Cr-Commit-Position: refs/heads/master@{#371647}
==========

[commit-bot: I haz the power, 2016-01-27 00:09:46]

Patchset 1 (id:??) landed as
https://crrev.com/5af0ca15f399f6cfa688441be25a86b2d6e62362
Cr-Commit-Position: refs/heads/master@{#371647}

[miu, 2016-01-27 01:09:25]

On 2016/01/26 23:10:42, hta - Chromium wrote:
> Before I start analyzing the CL - can you point me to the bug and the
diagnosis?
> 
> I've been trying quite hard to avoid changing existing behavior (to the point
> where we support > 50 different constraint names) - changing the behavior of
> other constraints because of a change I did to constraint behavior seems like
> the wrong thing to do.

Please see the bug link in the change description.  That has all the history. 
(BTW--You were assigned the issue at one point.)