Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 163113002: Mojo: Prefix user-defined parameter names to avoid conflicts (Closed)

Created:
6 years, 10 months ago by darin (slow to review)
Modified:
6 years, 10 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Prefix user-defined parameter names to avoid conflicts BUG=342543 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M mojo/public/bindings/generators/cpp_templates/interface_definition.tmpl View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
darin (slow to review)
6 years, 10 months ago (2014-02-13 08:13:08 UTC) #1
Matt Perry
lgtm
6 years, 10 months ago (2014-02-13 18:24:02 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 10 months ago (2014-02-13 20:45:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/163113002/1
6 years, 10 months ago (2014-02-13 20:49:13 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 23:06:56 UTC) #5
Message was sent while issue was closed.
Change committed as 251179

Powered by Google App Engine
This is Rietveld 408576698