tools/rebaseline.py - Issue 16311011: rebaseline.py: try to download images from Google Storage before skia-autogen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/rebaseline.py

Issue 16311011: rebaseline.py: try to download images from Google Storage before skia-autogen (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: sort_files_to_rebaseline Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/tests/rebaseline/output/all/output-expected/command_line » ('j') | tools/tests/rebaseline/output/using-json1-add-new/output-expected/stdout » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/rebaseline.py

===================================================================

--- tools/rebaseline.py (revision 9527)

+++ tools/rebaseline.py (working copy)

@@ -198,6 +198,7 @@

if section_results:

files_to_rebaseline.extend(section_results.keys())

+ files_to_rebaseline.sort()

epoger 2013/06/12 15:32:36 Patchset 2 sorts the files we will rebaseline, jus

print '# ... found files_to_rebaseline %s' % files_to_rebaseline

if self._dry_run:

print '#'

@@ -277,15 +278,16 @@

'should be one of %s') % (

subdir, SUBDIR_MAPPING.keys()))

builder_name = SUBDIR_MAPPING[subdir]

+ json_url = '/'.join([self._json_base_url,

+ subdir, builder_name, subdir,

+ self._json_filename])

if self._tests:

for test in self._tests:

self._RebaselineOneTest(expectations_subdir=subdir,

builder_name=builder_name,

test=test)

else: # get the raw list of files that need rebaselining from JSON

- json_url = '/'.join([self._json_base_url,

- subdir, builder_name, subdir,

- self._json_filename])

filenames = self._GetFilesToRebaseline(json_url=json_url,

add_new=self._add_new)

for filename in filenames: