Relocate ozone gbm overlay config cache to manager

Relocate ozone gbm overlay config cache to manager

The ozone gbm overlay candidate maintains a cache of layer configurations
that have previously been validated by the kernel display system. This is
unnecessary. Relocate the cache to the global overlay manager to simplify
the implementation of pluggable host to gpu communication.

BUG=558602
Committed: https://crrev.com/9c3ee3527aa66b14374cfe074e7132cf6d955887
Cr-Commit-Position: refs/heads/master@{#371696}

[rjkroege, 2016-01-25 22:50:16]

rjkroege@chromium.org changed reviewers:
+ kalyan.kondapally@chromium.org

[rjkroege, 2016-01-25 22:50:16]

ptal

[kalyank, 2016-01-25 23:43:43]

kalyan.kondapally@intel.com changed reviewers:
+ kalyan.kondapally@intel.com

[kalyank, 2016-01-25 23:43:44]

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
File ui/ozone/platform/drm/host/drm_overlay_candidates_host.h (right):

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
ui/ozone/platform/drm/host/drm_overlay_candidates_host.h:40:
DrmOverlayManagerCore* manager_core_;  // Not owned.
overlay_manager_ perhaps ?

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
File ui/ozone/platform/drm/host/drm_overlay_manager_core.cc (right):

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
ui/ozone/platform/drm/host/drm_overlay_manager_core.cc:129: //  if (widget !=
window_->GetAcceleratedWidget())
Forgot to remove this ?

[kalyank, 2016-01-26 00:43:40]

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
File ui/ozone/platform/drm/host/drm_overlay_manager_core.cc (right):

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
ui/ozone/platform/drm/host/drm_overlay_manager_core.cc:101: const
std::vector<OverlayCheck_Params>& validated_params = iter->first;
After thinking bit more about this, I don't feel comfortable that we ignore
widget here. For example even though layer combination might be same the widget
might be associated with a different display controller which could make these
results invalid.

[rjkroege, 2016-01-26 01:38:40]

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
File ui/ozone/platform/drm/host/drm_overlay_candidates_host.h (right):

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
ui/ozone/platform/drm/host/drm_overlay_candidates_host.h:40:
DrmOverlayManagerCore* manager_core_;  // Not owned.
On 2016/01/25 23:43:43, kalyank wrote:
> overlay_manager_ perhaps ?

Done.

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
File ui/ozone/platform/drm/host/drm_overlay_manager_core.cc (right):

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
ui/ozone/platform/drm/host/drm_overlay_manager_core.cc:101: const
std::vector<OverlayCheck_Params>& validated_params = iter->first;
On 2016/01/26 00:43:40, kalyank wrote:
> After thinking bit more about this, I don't feel comfortable that we ignore
> widget here. For example even though layer combination might be same the
widget
> might be associated with a different display controller which could make these
> results invalid.

This is why I wanted you to look at the patch. 

I think that that a widget will only be associated with a display controller on
creation or via a bounds change. In particular: the only way to change the
controller associated with a widget is to call DrmWindowHost::SetBounds. But
DrmWindowHost::SetBounds flushes the cache and WindowHost creation ends up
calling SetBounds (and hence flushes the cache).

Am I wrong? Do we invoke ScreenManager::UpdateControllerToWindowMapping any
other way?

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
ui/ozone/platform/drm/host/drm_overlay_manager_core.cc:129: //  if (widget !=
window_->GetAcceleratedWidget())
On 2016/01/25 23:43:43, kalyank wrote:
> Forgot to remove this ?

Done.

[kalyank_, 2016-01-26 02:36:39]

Non owner lgtm.

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
File ui/ozone/platform/drm/host/drm_overlay_manager_core.cc (right):

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
ui/ozone/platform/drm/host/drm_overlay_manager_core.cc:101: const
std::vector<OverlayCheck_Params>& validated_params = iter->first;
On 2016/01/26 01:38:40, rjkroege wrote:
> On 2016/01/26 00:43:40, kalyank wrote:
> > After thinking bit more about this, I don't feel comfortable that we ignore
> > widget here. For example even though layer combination might be same the
> widget
> > might be associated with a different display controller which could make
these
> > results invalid.
> 
> This is why I wanted you to look at the patch. 
> 
> I think that that a widget will only be associated with a display controller
on
> creation or via a bounds change. In particular: the only way to change the
> controller associated with a widget is to call DrmWindowHost::SetBounds. But
> DrmWindowHost::SetBounds flushes the cache and WindowHost creation ends up
> calling SetBounds (and hence flushes the cache).
> 
> Am I wrong? Do we invoke ScreenManager::UpdateControllerToWindowMapping any
> other way?
> 
> 
> 
> 

Acknowledged.

https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
ui/ozone/platform/drm/host/drm_overlay_manager_core.cc:101: const
std::vector<OverlayCheck_Params>& validated_params = iter->first;
On 2016/01/26 01:38:40, rjkroege wrote:
> On 2016/01/26 00:43:40, kalyank wrote:
> > After thinking bit more about this, I don't feel comfortable that we ignore
> > widget here. For example even though layer combination might be same the
> widget
> > might be associated with a different display controller which could make
these
> > results invalid.
> 
> This is why I wanted you to look at the patch. 
> 
> I think that that a widget will only be associated with a display controller
on
> creation or via a bounds change. In particular: the only way to change the
> controller associated with a widget is to call DrmWindowHost::SetBounds. But
> DrmWindowHost::SetBounds flushes the cache and WindowHost creation ends up
> calling SetBounds (and hence flushes the cache).
> 
> Am I wrong? Do we invoke ScreenManager::UpdateControllerToWindowMapping any
> other way?
> 
> 
> 

Ya that should be it. Also, I think as a future exercise with Mus we can get rid
of one the cache we have currently here and OverlayValidator.

[dnicoara, 2016-01-26 14:14:22]

dnicoara@chromium.org changed reviewers:
+ dnicoara@chromium.org

[dnicoara, 2016-01-26 14:14:23]

lgtm % nits

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_overlay_manager.cc (right):

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_overlay_manager.cc:43:
IPC_MESSAGE_FORWARD(OzoneHostMsg_OverlayCapabilitiesReceived, this,
nit: Since DrmOverlayManagerCore always handles this IPC, the IPC block should
be converted back to
IPC_BEGIN_MESSAGE_MAP()/IPC_MESSAGE_HANDLER()/IPC_MESSAGE_UNHANDLED(). Then
|handled| can be taken care of here and it no longer needs to be plumbed to
DrmOverlayManagerCore.

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_overlay_manager_core.h (right):

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_overlay_manager_core.h:11: //#include <map>
nit: Remove commented includes.

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_overlay_manager_core.h:27: virtual
~DrmOverlayManagerProxy() = 0;
Destructor needs an implementation.

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_window_host.cc (right):

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_window_host.cc:19: // #include
"ui/ozone/platform/drm/host/drm_overlay_candidates_host.h"
Remove commented include

[rjkroege, 2016-01-26 23:23:40]

On 2016/01/26 02:36:39, kalyank_ wrote:
> Non owner lgtm.
> 
>
https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
> File ui/ozone/platform/drm/host/drm_overlay_manager_core.cc (right):
> 
>
https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
> ui/ozone/platform/drm/host/drm_overlay_manager_core.cc:101: const
> std::vector<OverlayCheck_Params>& validated_params = iter->first;
> On 2016/01/26 01:38:40, rjkroege wrote:
> > On 2016/01/26 00:43:40, kalyank wrote:
> > > After thinking bit more about this, I don't feel comfortable that we
ignore
> > > widget here. For example even though layer combination might be same the
> > widget
> > > might be associated with a different display controller which could make
> these
> > > results invalid.
> > 
> > This is why I wanted you to look at the patch. 
> > 
> > I think that that a widget will only be associated with a display controller
> on
> > creation or via a bounds change. In particular: the only way to change the
> > controller associated with a widget is to call DrmWindowHost::SetBounds. But
> > DrmWindowHost::SetBounds flushes the cache and WindowHost creation ends up
> > calling SetBounds (and hence flushes the cache).
> > 
> > Am I wrong? Do we invoke ScreenManager::UpdateControllerToWindowMapping any
> > other way?
> > 
> > 
> > 
> > 
> 
> Acknowledged.
> 
>
https://codereview.chromium.org/1631073002/diff/1/ui/ozone/platform/drm/host/...
> ui/ozone/platform/drm/host/drm_overlay_manager_core.cc:101: const
> std::vector<OverlayCheck_Params>& validated_params = iter->first;
> On 2016/01/26 01:38:40, rjkroege wrote:
> > On 2016/01/26 00:43:40, kalyank wrote:
> > > After thinking bit more about this, I don't feel comfortable that we
ignore
> > > widget here. For example even though layer combination might be same the
> > widget
> > > might be associated with a different display controller which could make
> these
> > > results invalid.
> > 
> > This is why I wanted you to look at the patch. 
> > 
> > I think that that a widget will only be associated with a display controller
> on
> > creation or via a bounds change. In particular: the only way to change the
> > controller associated with a widget is to call DrmWindowHost::SetBounds. But
> > DrmWindowHost::SetBounds flushes the cache and WindowHost creation ends up
> > calling SetBounds (and hence flushes the cache).
> > 
> > Am I wrong? Do we invoke ScreenManager::UpdateControllerToWindowMapping any
> > other way?
> > 
> > 
> > 
> 
> Ya that should be it. Also, I think as a future exercise with Mus we can get
rid
> of one the cache we have currently here and OverlayValidator.

yes. Once mus is in production, we can definitely strip the redundant cache.

[rjkroege, 2016-01-26 23:58:56]

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_overlay_manager.cc (right):

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_overlay_manager.cc:43:
IPC_MESSAGE_FORWARD(OzoneHostMsg_OverlayCapabilitiesReceived, this,
On 2016/01/26 14:14:23, dnicoara wrote:
> nit: Since DrmOverlayManagerCore always handles this IPC, the IPC block should
> be converted back to
> IPC_BEGIN_MESSAGE_MAP()/IPC_MESSAGE_HANDLER()/IPC_MESSAGE_UNHANDLED(). Then
> |handled| can be taken care of here and it no longer needs to be plumbed to
> DrmOverlayManagerCore.

Done.

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_overlay_manager_core.h (right):

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_overlay_manager_core.h:11: //#include <map>
On 2016/01/26 14:14:23, dnicoara wrote:
> nit: Remove commented includes.

Done.

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_overlay_manager_core.h:27: virtual
~DrmOverlayManagerProxy() = 0;
On 2016/01/26 14:14:23, dnicoara wrote:
> Destructor needs an implementation.

Done.

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_window_host.cc (right):

https://codereview.chromium.org/1631073002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_window_host.cc:19: // #include
"ui/ozone/platform/drm/host/drm_overlay_candidates_host.h"
On 2016/01/26 14:14:23, dnicoara wrote:
> Remove commented include

Done.

[rjkroege, 2016-01-26 23:59:09]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-01-26 23:59:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org, kalyan.kondapally@chromium.org
Link to the patchset: https://codereview.chromium.org/1631073002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-01-26 23:59:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631073002/40001

[commit-bot: I haz the power, 2016-01-27 00:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 00:06:49]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[rjkroege, 2016-01-27 00:59:59]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-01-27 00:59:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org, kalyan.kondapally@chromium.org
Link to the patchset: https://codereview.chromium.org/1631073002/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-01-27 01:04:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631073002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631073002/60001

[commit-bot: I haz the power, 2016-01-27 01:10:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:10:54]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rjkroege, 2016-01-27 02:17:12]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-01-27 02:17:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org, kalyan.kondapally@chromium.org
Link to the patchset: https://codereview.chromium.org/1631073002/#ps80001
(title: "rebased correctly")

[commit-bot: I haz the power, 2016-01-27 02:18:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631073002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631073002/80001

[commit-bot: I haz the power, 2016-01-27 03:06:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-27 03:08:24]

Description was changed from

==========
Relocate ozone gbm overlay config cache to manager

The ozone gbm overlay candidate maintains a cache of layer configurations
that have previously been validated by the kernel display system. This is
unnecessary. Relocate the cache to the global overlay manager to simplify
the implementation of pluggable host to gpu communication.

BUG=558602
==========

to

==========
Relocate ozone gbm overlay config cache to manager

The ozone gbm overlay candidate maintains a cache of layer configurations
that have previously been validated by the kernel display system. This is
unnecessary. Relocate the cache to the global overlay manager to simplify
the implementation of pluggable host to gpu communication.

BUG=558602

Committed: https://crrev.com/9c3ee3527aa66b14374cfe074e7132cf6d955887
Cr-Commit-Position: refs/heads/master@{#371696}
==========

[commit-bot: I haz the power, 2016-01-27 03:08:25]

Patchset 5 (id:??) landed as
https://crrev.com/9c3ee3527aa66b14374cfe074e7132cf6d955887
Cr-Commit-Position: refs/heads/master@{#371696}