third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp - Issue 1631063002: Add isPageVisible to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

Issue 1631063002: Add isPageVisible to Page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Clean up Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/Page.cpp ('K') | « third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp b/third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

index e6522021aa0d96d8f4fe711562661881b70db2a5..88a65026da54ed47d54371c8f79176708f583de0 100644

--- a/third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

@@ -90,7 +90,7 @@ void GeolocationController::addObserver(Geolocation* observer, bool enableHighAc

if (m_client) {

if (enableHighAccuracy)

m_client->setEnableHighAccuracy(true);

- if (wasEmpty && page() && page()->visibilityState() == PageVisibilityStateVisible)

+ if (wasEmpty && page() && page()->isPageVisible())

startUpdatingIfNeeded();

}

@@ -170,7 +170,7 @@ void GeolocationController::pageVisibilityChanged()

if (m_observers.isEmpty() || !m_client)

return;

- if (page() && page()->visibilityState() == PageVisibilityStateVisible)

+ if (page() && page()->isPageVisible())

startUpdatingIfNeeded();

else

stopUpdatingIfNeeded();