[css-flexbox] For now, don't apply min-height: auto to nested flexboxes

[css-flexbox] For now, don't apply min-height: auto to nested flexboxes

Our handling of it is pretty incorrect, leading to very poor results. See the testcase in the bug.

This was caused by https://codereview.chromium.org/1421423005

BUG=580196
R=leviw@chromium.org

Committed: https://crrev.com/b883e94b36fe4f3f3f71e24626ed9e0678372085
Cr-Commit-Position: refs/heads/master@{#371699}

[cbiesinger, 2016-01-25 23:24:13]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 23:26:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631033003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631033003/1

[commit-bot: I haz the power, 2016-01-26 02:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 02:19:07]

Dry run: This issue passed the CQ dry run.

[leviw_travelin_and_unemployed, 2016-01-27 00:18:30]

Mention that https://codereview.chromium.org/1421423005 triggered this
regression to the description.

LGTM.

https://codereview.chromium.org/1631033003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp (right):

https://codereview.chromium.org/1631033003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:915: } else if
(min.isAuto() && mainAxisOverflowForChild(child) == OVISIBLE && !(isColumnFlow()
&& child.isFlexibleBox())) {
*Sigh*

This sucks, but I agree with it as a bandaid :-/

https://codereview.chromium.org/1631033003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:918: // reasonable
results.
Tracking bug?

[cbiesinger, 2016-01-27 00:20:28]

Description was changed from

==========
[css-flexbox] For now, don't apply min-height: auto to nested flexboxes

Our handling of it is pretty incorrect, leading to very poor results.

BUG=580196
R=leviw@chromium.org
==========

to

==========
[css-flexbox] For now, don't apply min-height: auto to nested flexboxes

Our handling of it is pretty incorrect, leading to very poor results. See the
testcase in the bug.

This was caused by https://codereview.chromium.org/1421423005

BUG=580196
R=leviw@chromium.org
==========

[cbiesinger, 2016-01-27 00:25:08]

Thanks, sending to cq now.

https://codereview.chromium.org/1631033003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp (right):

https://codereview.chromium.org/1631033003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:918: // reasonable
results.
On 2016/01/27 00:18:30, leviw wrote:
> Tracking bug?

Done.

[cbiesinger, 2016-01-27 00:25:13]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-01-27 00:25:13]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1631033003/#ps20001
(title: "review comment")

[commit-bot: I haz the power, 2016-01-27 00:25:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631033003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631033003/20001

[commit-bot: I haz the power, 2016-01-27 03:10:42]

Description was changed from

==========
[css-flexbox] For now, don't apply min-height: auto to nested flexboxes

Our handling of it is pretty incorrect, leading to very poor results. See the
testcase in the bug.

This was caused by https://codereview.chromium.org/1421423005

BUG=580196
R=leviw@chromium.org
==========

to

==========
[css-flexbox] For now, don't apply min-height: auto to nested flexboxes

Our handling of it is pretty incorrect, leading to very poor results. See the
testcase in the bug.

This was caused by https://codereview.chromium.org/1421423005

BUG=580196
R=leviw@chromium.org
==========

[commit-bot: I haz the power, 2016-01-27 03:10:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 03:12:49]

Description was changed from

==========
[css-flexbox] For now, don't apply min-height: auto to nested flexboxes

Our handling of it is pretty incorrect, leading to very poor results. See the
testcase in the bug.

This was caused by https://codereview.chromium.org/1421423005

BUG=580196
R=leviw@chromium.org
==========

to

==========
[css-flexbox] For now, don't apply min-height: auto to nested flexboxes

Our handling of it is pretty incorrect, leading to very poor results. See the
testcase in the bug.

This was caused by https://codereview.chromium.org/1421423005

BUG=580196
R=leviw@chromium.org

Committed: https://crrev.com/b883e94b36fe4f3f3f71e24626ed9e0678372085
Cr-Commit-Position: refs/heads/master@{#371699}
==========

[commit-bot: I haz the power, 2016-01-27 03:12:50]

Patchset 2 (id:??) landed as
https://crrev.com/b883e94b36fe4f3f3f71e24626ed9e0678372085
Cr-Commit-Position: refs/heads/master@{#371699}

[cbiesinger, 2016-02-01 22:33:54]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[cbiesinger, 2016-02-01 22:34:14]

Patchset #3 (id:40001) has been deleted