Fix sysroot_ld_path.sh to correctly process the included configs.

Fix sysroot_ld_path.sh to correctly process the included configs.

The $included_files var contains a list of paths relative to the sysroot.
However calling `ls $included_files` gives us a list of paths relative to the host system root, which is obviously wrong. We need to do `ls $root$included_files` instead.

BUG=324207
R=thestig@chromium.org
CC=sl.ostapenko@samsung.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251356

[Alexander Potapenko, 2014-02-13 08:48:02]

Please take a look.
Without this change sysroot_ld_path.sh fails for me when I'm trying to use a
32-bit Precise sysroot on a 64-bit Precise host system.

[Lei Zhang, 2014-02-13 09:26:18]

It's the middle of the night for me, so check what I write carefully. :)

https://codereview.chromium.org/163103003/diff/1/build/linux/sysroot_ld_path.sh
File build/linux/sysroot_ld_path.sh (right):

https://codereview.chromium.org/163103003/diff/1/build/linux/sysroot_ld_path....
build/linux/sysroot_ld_path.sh:49: if ls $root$included_files >/dev/null 2>&1 ;
then
In the absolute case, $included_files = /foo/*, we want to do:
ls $root/$included_files, which expands out to:
/abspath/to/sysroot/foo/*

but in the relative case, $included_files = bar/*, we want to do just:
ls $include_files, which expands out to:
bar/*

and that's fine because $PWD is already somewhere under /abspath/to/sysroot/etc

So what you want here is probably:

echo "$included_files" | grep -qs ^/
if [ $? -eq 0 ]; then
  for inc_file in $root$included_files; do
    process_ld_so_conf "$root" "$inc_file"
  done
else
  for inc_file in $(pwd)/$included_files; do
    process_ld_so_conf "$root" "$inc_file"
  done
fi

[Alexander Potapenko, 2014-02-13 10:49:19]

Seems to work (PS2)
Are there trybots exploiting this code?

[Lei Zhang, 2014-02-13 10:53:54]

On 2014/02/13 10:49:19, Alexander Potapenko wrote:
> Seems to work (PS2)
> Are there trybots exploiting this code?

Maybe linux_arm_cross_compile?

lgtm with the file existence check added back in.

https://codereview.chromium.org/163103003/diff/60001/build/linux/sysroot_ld_p...
File build/linux/sysroot_ld_path.sh (right):

https://codereview.chromium.org/163103003/diff/60001/build/linux/sysroot_ld_p...
build/linux/sysroot_ld_path.sh:51: for inc_file in $root$included_files; do
Oh, we need to check and make sure $included_files exists.

if ls $root$included_files >/dev/null 2>&1 ; then
  for inc_file ...
fi

Same for the else case below.

[Alexander Potapenko, 2014-02-13 13:34:32]

Done.
Will commit when the bot passes.

[Lei Zhang, 2014-02-13 19:17:06]

lgtm

[Alexander Potapenko, 2014-02-14 17:03:22]

Committed patchset #3 manually as r251356 (presubmit successful).