Fix moving the mouse between two displays after the secondary display becomes primary.

Fix moving the mouse between two displays after the secondary display becomes primary.

BUG=580754
Committed: https://crrev.com/3c2d523b0549c0d5139e76132da313eb2935a511
Cr-Commit-Position: refs/heads/master@{#371566}

[stevenjb, 2016-01-25 21:42:55]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-01-25 21:42:56]

https://codereview.chromium.org/1631023002/diff/1/ash/display/extended_mouse_...
File ash/display/extended_mouse_warp_controller.h (right):

https://codereview.chromium.org/1631023002/diff/1/ash/display/extended_mouse_...
ash/display/extended_mouse_warp_controller.h:81:
scoped_ptr<SharedDisplayEdgeIndicator> shared_display_edge_indicator;
All members should be named with a trailing _ and made private with accessors
provided for members that need to be read outside of the class.

https://codereview.chromium.org/1631023002/diff/1/ash/display/window_tree_hos...
File ash/display/window_tree_host_manager.cc (left):

https://codereview.chromium.org/1631023002/diff/1/ash/display/window_tree_hos...
ash/display/window_tree_host_manager.cc:466:
GetDisplayManager()->UpdateDisplays(display_info_list);
Can we now rename DisplayManager::UpdateDisplays(vector) to
DisplayManager::UpdateDisplaysImpl(vector) so we don't have the unfortunate
situation where DisplayManager has two methods with the same name (we strongly
discourage that in Chrome)? This appears to have been the only place outside of
DisplayManager where the (vector) version is called.

[jdufault, 2016-01-25 22:48:46]

jdufault@chromium.org changed reviewers:
+ oshima@chromium.org

[jdufault, 2016-01-25 22:48:46]

Oshima, PTAL. Thanks!

https://codereview.chromium.org/1631023002/diff/1/ash/display/extended_mouse_...
File ash/display/extended_mouse_warp_controller.h (right):

https://codereview.chromium.org/1631023002/diff/1/ash/display/extended_mouse_...
ash/display/extended_mouse_warp_controller.h:81:
scoped_ptr<SharedDisplayEdgeIndicator> shared_display_edge_indicator;
On 2016/01/25 21:42:55, stevenjb wrote:
> All members should be named with a trailing _ and made private with accessors
> provided for members that need to be read outside of the class.

Done.

https://codereview.chromium.org/1631023002/diff/1/ash/display/window_tree_hos...
File ash/display/window_tree_host_manager.cc (left):

https://codereview.chromium.org/1631023002/diff/1/ash/display/window_tree_hos...
ash/display/window_tree_host_manager.cc:466:
GetDisplayManager()->UpdateDisplays(display_info_list);
On 2016/01/25 21:42:55, stevenjb wrote:
> Can we now rename DisplayManager::UpdateDisplays(vector) to
> DisplayManager::UpdateDisplaysImpl(vector) so we don't have the unfortunate
> situation where DisplayManager has two methods with the same name (we strongly
> discourage that in Chrome)? This appears to have been the only place outside
of
> DisplayManager where the (vector) version is called.

There are some tests that use the method. Given that, what do you think of
renaming UpdateDisplays(vector) to UpdateDisplaysTo(vector)?

[oshima, 2016-01-25 23:47:36]

https://codereview.chromium.org/1631023002/diff/20001/ash/display/display_man...
File ash/display/display_manager.h (right):

https://codereview.chromium.org/1631023002/diff/20001/ash/display/display_man...
ash/display/display_manager.h:228: void UpdateDisplaysTo(const
std::vector<DisplayInfo>& display_info_list);
This is a bit misleading as the configured displays may or may not be same as
passed info. If you want to change, UpdateDisplaysWith would be better.

[stevenjb, 2016-01-25 23:56:06]

lgtm w/ name change suggested by oshima

[jdufault, 2016-01-26 18:37:03]

https://codereview.chromium.org/1631023002/diff/20001/ash/display/display_man...
File ash/display/display_manager.h (right):

https://codereview.chromium.org/1631023002/diff/20001/ash/display/display_man...
ash/display/display_manager.h:228: void UpdateDisplaysTo(const
std::vector<DisplayInfo>& display_info_list);
On 2016/01/25 23:47:36, oshima wrote:
> This is a bit misleading as the configured displays may or may not be same as
> passed info. If you want to change, UpdateDisplaysWith would be better.

Done.

[oshima, 2016-01-26 18:47:30]

lgtm

[jdufault, 2016-01-26 19:07:26]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-01-26 19:07:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1631023002/#ps40001
(title: "Rename UpdateDisplaysTo to UpdateDisplaysWith")

[commit-bot: I haz the power, 2016-01-26 19:07:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631023002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631023002/40001

[commit-bot: I haz the power, 2016-01-26 19:46:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-26 19:47:13]

Description was changed from

==========
Fix moving the mouse between two displays after the secondary display becomes
primary.

BUG=580754
==========

to

==========
Fix moving the mouse between two displays after the secondary display becomes
primary.

BUG=580754

Committed: https://crrev.com/3c2d523b0549c0d5139e76132da313eb2935a511
Cr-Commit-Position: refs/heads/master@{#371566}
==========

[commit-bot: I haz the power, 2016-01-26 19:47:14]

Patchset 3 (id:??) landed as
https://crrev.com/3c2d523b0549c0d5139e76132da313eb2935a511
Cr-Commit-Position: refs/heads/master@{#371566}