Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1631003002: Revert of Exclude all ash test on DrMemory (Closed)

Created:
4 years, 11 months ago by oshima
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Exclude all ash test on DrMemory (patchset #1 id:1 of https://codereview.chromium.org/1627893004/ ) Reason for revert: This didn't help. reverting Original issue's description: > Exclude all ash test on DrMemory > > BUG=558054 > TBR=scottmg@chromium.org > > Committed: https://crrev.com/144307209c8d8615bb29d8fb613367a155907c0f > Cr-Commit-Position: refs/heads/master@{#371210} TBR=scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=558054 Committed: https://crrev.com/d92276bd267ec72a0aa1d661be7c47c6d3c82e7d Cr-Commit-Position: refs/heads/master@{#371316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
D tools/valgrind/gtest_exclude/ash_unittests.gtest-drmemory.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
oshima
Created Revert of Exclude all ash test on DrMemory
4 years, 11 months ago (2016-01-25 21:18:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631003002/1
4 years, 11 months ago (2016-01-25 21:19:07 UTC) #2
scottmg
lgtm Sorry for the confusion, ash_unittests is removed from drmemory bots now, but requires infra ...
4 years, 11 months ago (2016-01-25 21:21:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 21:24:00 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 21:26:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d92276bd267ec72a0aa1d661be7c47c6d3c82e7d
Cr-Commit-Position: refs/heads/master@{#371316}

Powered by Google App Engine
This is Rietveld 408576698