Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 16310007: [OTS] Fix assertion failure on Windows debug build (Closed)

Created:
7 years, 6 months ago by Kunihiko Sakamoto
Modified:
7 years, 6 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Visibility:
Public.

Description

[OTS] Fix assertion failure on Windows debug build * In Windows debug build, vector::operator[] does boundary check and &vec[vec.size()] causes assertion failure. * Make sure FILEStream::Seek returns false on error. R=yusukes@chromium.org Committed: 102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/woff2.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/file-stream.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Kunihiko Sakamoto
Yusuke-san, could you take a look?
7 years, 6 months ago (2013-06-07 09:31:22 UTC) #1
Yusuke Sato
lgtm
7 years, 6 months ago (2013-06-07 21:04:21 UTC) #2
Kunihiko Sakamoto
7 years, 6 months ago (2013-06-07 22:37:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698