Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1630983002: Move bulk of event_with_latency_info into common. (Closed)

Created:
4 years, 11 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_wheel_passive_listeners_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move bulk of event_with_latency_info into common. Move the definition of EventWithLatencyInfo into common for code reuse with a later change. BUG=489802 Committed: https://crrev.com/d94b93a1c0ae2a1d49d78834284d54ad114ae38e Cr-Commit-Position: refs/heads/master@{#372462}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -171 lines) Patch
M content/browser/renderer_host/event_with_latency_info.h View 1 chunk +1 line, -54 lines 0 comments Download
D content/browser/renderer_host/event_with_latency_info_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
A + content/common/input/event_with_latency_info.h View 3 chunks +3 lines, -6 lines 0 comments Download
A + content/common/input/event_with_latency_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dtapuska
4 years, 11 months ago (2016-01-25 21:02:37 UTC) #3
tdresser
https://codereview.chromium.org/1630983002/diff/1/content/browser/renderer_host/event_with_latency_info.h File content/browser/renderer_host/event_with_latency_info.h (right): https://codereview.chromium.org/1630983002/diff/1/content/browser/renderer_host/event_with_latency_info.h#newcode14 content/browser/renderer_host/event_with_latency_info.h:14: NativeWebKeyboardEventWithLatencyInfo; Why can't this move as well? It's a ...
4 years, 11 months ago (2016-01-26 13:40:22 UTC) #4
dtapuska
https://codereview.chromium.org/1630983002/diff/1/content/browser/renderer_host/event_with_latency_info.h File content/browser/renderer_host/event_with_latency_info.h (right): https://codereview.chromium.org/1630983002/diff/1/content/browser/renderer_host/event_with_latency_info.h#newcode14 content/browser/renderer_host/event_with_latency_info.h:14: NativeWebKeyboardEventWithLatencyInfo; On 2016/01/26 13:40:22, tdresser wrote: > Why can't ...
4 years, 11 months ago (2016-01-26 14:16:16 UTC) #5
tdresser
LGTM https://codereview.chromium.org/1630983002/diff/1/content/browser/renderer_host/event_with_latency_info.h File content/browser/renderer_host/event_with_latency_info.h (right): https://codereview.chromium.org/1630983002/diff/1/content/browser/renderer_host/event_with_latency_info.h#newcode14 content/browser/renderer_host/event_with_latency_info.h:14: NativeWebKeyboardEventWithLatencyInfo; On 2016/01/26 14:16:16, dtapuska wrote: > On ...
4 years, 11 months ago (2016-01-26 14:20:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630983002/20001
4 years, 10 months ago (2016-01-29 22:05:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 23:23:36 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 23:25:03 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d94b93a1c0ae2a1d49d78834284d54ad114ae38e
Cr-Commit-Position: refs/heads/master@{#372462}

Powered by Google App Engine
This is Rietveld 408576698