Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1630973002: Remove struct PARSE_OPTIONS. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Remove struct PARSE_OPTIONS. Its members are assigned to, but never used in any calculations (besides for other members). R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0f68785be6af2b15109bb8a8f3bb7ebc040500d5

Patch Set 1 #

Patch Set 2 : Rebase, prior merge suspect. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -99 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 2 chunks +1 line, -2 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 5 chunks +4 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 4 chunks +7 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 34 chunks +29 lines, -61 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review.
4 years, 11 months ago (2016-01-25 20:29:52 UTC) #1
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-25 21:32:44 UTC) #2
Tom Sepez
4 years, 11 months ago (2016-01-25 21:37:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0f68785be6af2b15109bb8a8f3bb7ebc040500d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698