Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: test/codegen/expect/closure.js

Issue 1630963003: Use a symbol for static length/name (conflicts with Function properties in ES5: cannot redefine Fun… (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: left todo Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/closure.dart ('k') | test/codegen/expect/names.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/codegen/expect/closure.js
diff --git a/test/codegen/expect/closure.js b/test/codegen/expect/closure.js
index b33e351fec2f42119f7e7e2b68a55de6ff99028f..c347f8928790f541df3f4234485b6b1cabc1da08 100644
--- a/test/codegen/expect/closure.js
+++ b/test/codegen/expect/closure.js
@@ -67,6 +67,21 @@ dart_library.library('closure', null, /* Imports */[
let b = opts && 'b' in opts ? opts.b : null;
let c = opts && 'c' in opts ? opts.c : null;
}
+ static [dartx.name]() {
+ return 'Foo.name()';
+ }
+ static [dartx.length]() {
+ return 'Foo.length()';
+ }
+ static [dartx.arguments]() {
+ return 'Foo.arguments()';
+ }
+ static [dartx.caller]() {
+ return 'Foo.caller()';
+ }
+ static [dartx.callee]() {
+ return 'Foo.callee()';
+ }
nullary_method() {}
/**
* @param {function(?, ?=):?number} f
@@ -104,8 +119,15 @@ dart_library.library('closure', null, /* Imports */[
nullary_method: [dart.dynamic, []],
function_params: [dart.dynamic, [dart.functionType(core.int, [dart.dynamic], [dart.dynamic]), dart.functionType(dart.dynamic, [dart.dynamic], {y: core.String, z: dart.dynamic}), Callback]]
}),
- statics: () => ({named_params: [dart.dynamic, [dart.dynamic], {b: dart.dynamic, c: dart.dynamic}]}),
- names: ['named_params']
+ statics: () => ({
+ named_params: [dart.dynamic, [dart.dynamic], {b: dart.dynamic, c: dart.dynamic}],
+ [dartx.name]: [dart.dynamic, []],
+ [dartx.length]: [dart.dynamic, []],
+ [dartx.arguments]: [dart.dynamic, []],
+ [dartx.caller]: [dart.dynamic, []],
+ [dartx.callee]: [dart.dynamic, []]
+ }),
+ names: ['named_params', dartx.name, dartx.length, dartx.arguments, dartx.caller, dartx.callee]
});
/** @final {string} */
Foo.some_static_constant = "abc";
@@ -128,6 +150,11 @@ dart_library.library('closure', null, /* Imports */[
});
/** @param {?} args */
function main(args) {
+ core.print(Foo[dartx.name]());
+ core.print(Foo[dartx.length]());
+ core.print(Foo[dartx.arguments]());
+ core.print(Foo[dartx.caller]());
+ core.print(Foo[dartx.callee]());
}
dart.fn(main, dart.void, [dart.dynamic]);
/** @final {string} */
@@ -136,6 +163,13 @@ dart_library.library('closure', null, /* Imports */[
exports.some_top_level_final = "abc";
/** @type {string} */
exports.some_top_level_var = "abc";
+ dart.defineExtensionNames([
+ "name",
+ "length",
+ "arguments",
+ "caller",
+ "callee"
+ ]);
// Exports:
exports.Callback = Callback;
exports.Foo$ = Foo$;
« no previous file with comments | « test/codegen/closure.dart ('k') | test/codegen/expect/names.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698