Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1630953003: Remove invalid CHECK() from DesktopSessionAgent::OnCaptureCompleted. (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 11 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove invalid CHECK() from DesktopSessionAgent::OnCaptureCompleted. crrev.com/370480 added a CHECK() in DesktopSessionAgent. It was added there in last minute during review and it wasn't properly validated. It's supposed to verify that the screen capturer actually uses the shared memory given to it by verifying that frame->data() and shared_memory->data() return the same address. On windows the capturer maps uses shared_memory->handle() to allocate bitmap, so the same file mapping ends up mapped in two different addresses. So frame->data() and shared_memory->data() are different addresses, but the data they contain is always the same. BUG=575427 Committed: https://crrev.com/f545a8581d72cdf8a39d4d5fec23e728e2ca089f Cr-Commit-Position: refs/heads/master@{#371321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M remoting/host/desktop_session_agent.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
4 years, 11 months ago (2016-01-25 20:49:23 UTC) #2
joedow
lgtm
4 years, 11 months ago (2016-01-25 20:53:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630953003/1
4 years, 11 months ago (2016-01-25 20:56:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 21:41:04 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 21:44:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f545a8581d72cdf8a39d4d5fec23e728e2ca089f
Cr-Commit-Position: refs/heads/master@{#371321}

Powered by Google App Engine
This is Rietveld 408576698