DescriptionRemove invalid CHECK() from DesktopSessionAgent::OnCaptureCompleted.
crrev.com/370480 added a CHECK() in DesktopSessionAgent. It was
added there in last minute during review and it wasn't properly
validated.
It's supposed to verify that the screen capturer actually uses
the shared memory given to it by verifying that frame->data() and
shared_memory->data() return the same address. On windows the capturer
maps uses shared_memory->handle() to allocate bitmap, so the same
file mapping ends up mapped in two different addresses. So
frame->data() and shared_memory->data() are different addresses, but
the data they contain is always the same.
BUG=575427
Committed: https://crrev.com/f545a8581d72cdf8a39d4d5fec23e728e2ca089f
Cr-Commit-Position: refs/heads/master@{#371321}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|