Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 1630933004: Fix type-error in base64.dart (Closed)

Created:
4 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 10 months ago
Reviewers:
nweiz, floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M sdk/lib/convert/base64.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/convert/base64_test.dart View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Lasse Reichstein Nielsen
4 years, 11 months ago (2016-01-26 07:23:36 UTC) #2
Lasse Reichstein Nielsen
4 years, 10 months ago (2016-01-28 12:15:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d6b01b5028603f1bf2ee8331761b2b16bea288f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698