chrome/chrome_common.gypi - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: de-dup is_win blocks in GN too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index c53545f99775c9f265f839206e3b1415eeb822b8..725df2308ff727ed95db7fcf7f3646dfd9bb2e01 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -657,4 +657,23 @@

+ 'conditions': [

+ ['OS == "win"', {

+ 'targets': [

+ {

+ # GN version: //chrome/common:metrics_constants_util_win

+ 'target_name': 'metrics_constants_util_win',

+ 'type': 'static_library',

+ 'sources': [

+ 'common/metrics_constants_util_win.cc',

+ 'common/metrics_constants_util_win.h',

+ ],

+ 'dependencies': [

+ 'installer_util',

+ '../base/base.gyp:base',

+ ],

+ },

+ ],

+ }],

+ ],

}

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »