chrome/browser/BUILD.gn - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: de-dup is_win blocks in GN too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 8b8b293611f1989af8415a17163abcbb5099946a..db3ca8552dd3d8d95d8e6b59abcb716bd4f1287b 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -439,9 +439,6 @@ source_set("browser") {

"//chrome/browser/apps/app_shim",

]

}

- if (is_win) {

- deps += [ "//chrome:file_pre_reader" ]

- }

if (is_mac || is_android) {

sources += rebase_path(

gypi_values.chrome_browser_password_manager_mac_android_sources,

@@ -836,8 +833,10 @@ source_set("browser") {

]

deps += [

":chrome_process_finder",

+ "//chrome:file_pre_reader",

"//chrome/chrome_watcher:client",

"//chrome/chrome_watcher:kasko_util",

+ "//chrome/common:metrics_constants_util_win",

"//chrome/common:version_header",

"//chrome/installer/util:strings",

"//chrome_elf",

« no previous file with comments | « chrome/app/main_dll_loader_win.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »