Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

chrome/common/BUILD.gn

Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 7f197ce3a35790049c65690a87abe60229b037c5..fce2ed19c63cb9d0fef1ca25a2a54aa502e3b219 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -351,6 +351,19 @@ static_library("constants") {
   }
 }
 
+# GYP version: chrome/chrome_common.gypi:metrics_constants_util_win

[grt (UTC plus 2), 2016/04/15 15:29:32]

how about defining this in an is_win block?

[gab, 2016/04/15 18:14:07]

Done. The dependency for chrome_initial target was already in an is_win block,
the chrome_watcher one isn't but the whole target is win-only (it just isn't
explicit, nor is it in GYP, and I'm not going to address that), the new
'browser' dependency wasn't but I moved it to the is_win block too.

+source_set("metrics_constants_util_win") {
+  sources = [
+    "metrics_constants_util_win.cc",
+    "metrics_constants_util_win.h",
+  ]
+
+  deps = [
+    "//base",
+    "//chrome/installer/util:with_no_strings",
+  ]
+}
+
 source_set("test_support") {
   testonly = true
   visibility = [ "//chrome/test:test_support" ]
@@ -382,7 +395,7 @@ source_set("test_support") {
   }
 }
 
-# GN version: chrome/chrome.gyp:app_mode_app_support
+# GYP version: chrome/chrome.gyp:app_mode_app_support
 source_set("app_mode_app_support") {
   sources = [
     "mac/app_mode_chrome_locator.h",