Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6092)

Unified Diff: chrome/chrome_common.gypi

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter
Patch Set: nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_common.gypi
diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi
index c53545f99775c9f265f839206e3b1415eeb822b8..bc944ea55e63a5c3b53ec6fdabef8edaf898279a 100644
--- a/chrome/chrome_common.gypi
+++ b/chrome/chrome_common.gypi
@@ -656,5 +656,18 @@
'../skia/skia.gyp:skia_mojo',
],
},
+ {
+ # GN version: //chrome/common:metrics_constants_util_win
grt (UTC plus 2) 2016/04/15 15:29:32 i think it's entirely appropriate to put this in a
gab 2016/04/15 18:14:06 Didn't initially think that was the right way but
+ 'target_name': 'metrics_constants_util_win',
+ 'type': 'static_library',
+ 'sources': [
+ 'common/metrics_constants_util_win.cc',
+ 'common/metrics_constants_util_win.h',
+ ],
+ 'dependencies': [
+ 'installer_util',
+ '../base/base.gyp:base',
+ ],
+ },
],
}

Powered by Google App Engine
This is Rietveld 408576698