Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: chrome/browser/metrics/chrome_stability_metrics_provider.cc

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter
Patch Set: nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_stability_metrics_provider.cc
diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider.cc b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
index c8145ab3a203711387ecc8b2699b822300b2d17c..3c94a839446ecafa39539555a76bf509cd6d71f4 100644
--- a/chrome/browser/metrics/chrome_stability_metrics_provider.cc
+++ b/chrome/browser/metrics/chrome_stability_metrics_provider.cc
@@ -11,7 +11,6 @@
#include "base/metrics/sparse_histogram.h"
#include "build/build_config.h"
#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/common/chrome_constants.h"
#include "content/public/browser/child_process_data.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_process_host.h"
@@ -26,7 +25,7 @@
#if defined(OS_WIN)
#include <windows.h> // Needed for STATUS_* codes
-#include "chrome/installer/util/install_util.h"
+#include "chrome/common/metrics_constants_util_win.h"
#include "components/browser_watcher/crash_reporting_metrics_win.h"
#endif
@@ -43,9 +42,7 @@ void CountBrowserCrashDumpAttempts() {
browser_watcher::CrashReportingMetrics::Values metrics =
browser_watcher::CrashReportingMetrics(
- InstallUtil::IsChromeSxSProcess()
- ? chrome::kBrowserCrashDumpAttemptsRegistryPathSxS
- : chrome::kBrowserCrashDumpAttemptsRegistryPath)
+ chrome::GetBrowserCrashDumpAttemptsRegistryPath())
.RetrieveAndResetMetrics();
for (int i = 0; i < metrics.crash_dump_attempts; ++i) {

Powered by Google App Engine
This is Rietveld 408576698