components/browser_watcher/exit_code_watcher_win.cc - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_watcher/exit_code_watcher_win.cc

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: rebase on r373339 and rm unused install_util.h include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/chrome_constants_util_win.cc ('K') | « components/browser_watcher/exit_code_watcher_win.h ('k') | components/browser_watcher/watcher_metrics_provider_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_watcher/exit_code_watcher_win.cc

diff --git a/components/browser_watcher/exit_code_watcher_win.cc b/components/browser_watcher/exit_code_watcher_win.cc

index 0e2318472f455a2c9f40b4b2b12622aa9eca7e68..70366de8ada87ec92f913f022e43eac9fc1a080e 100644

--- a/components/browser_watcher/exit_code_watcher_win.cc

+++ b/components/browser_watcher/exit_code_watcher_win.cc

@@ -22,8 +22,8 @@ base::string16 GetValueName(const base::Time creation_time,

} // namespace

-ExitCodeWatcher::ExitCodeWatcher(const base::char16* registry_path) :

- registry_path_(registry_path), exit_code_(STILL_ACTIVE) {

+ExitCodeWatcher::ExitCodeWatcher(base::StringPiece16 registry_path) :

+ registry_path_(registry_path.as_string()), exit_code_(STILL_ACTIVE) {

}

ExitCodeWatcher::~ExitCodeWatcher() {