chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: rebase on r373339 and rm unused install_util.h include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/main_dll_loader_win.cc ('k') | chrome/browser/metrics/chrome_stability_metrics_provider.cc » ('j') | chrome/common/chrome_constants_util_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 5d2a3fb00383f51b6109483e3c3c0002fc76d9f0..6bb5418483cbd5a40b97eb5252b0b340586eb353 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -25,7 +25,6 @@

#include "chrome/browser/metrics/time_ticks_experiment_win.h"

#include "chrome/browser/ui/browser_otr_state.h"

#include "chrome/common/channel_info.h"

-#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/crash_keys.h"

@@ -76,6 +75,7 @@

#if defined(OS_WIN)

#include <windows.h>

#include "chrome/browser/metrics/google_update_metrics_provider_win.h"

+#include "chrome/common/chrome_constants_util_win.h"

#include "chrome/installer/util/browser_distribution.h"

#include "components/browser_watcher/watcher_metrics_provider_win.h"

#endif

@@ -365,7 +365,7 @@ void ChromeMetricsServiceClient::Initialize() {

metrics_service_->RegisterMetricsProvider(

scoped_ptr<metrics::MetricsProvider>(

new browser_watcher::WatcherMetricsProviderWin(

- chrome::kBrowserExitCodesRegistryPath,

+ chrome::GetBrowserExitCodesRegistryPath(),

content::BrowserThread::GetBlockingPool())));

#endif // defined(OS_WIN)