components/browser_watcher/exit_code_watcher_win.h - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_watcher/exit_code_watcher_win.h

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/chrome_constants.cc ('K') | « chrome/common/chrome_constants.cc ('k') | components/browser_watcher/exit_code_watcher_win.cc » ('j') | components/browser_watcher/watcher_metrics_provider_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_watcher/exit_code_watcher_win.h

diff --git a/components/browser_watcher/exit_code_watcher_win.h b/components/browser_watcher/exit_code_watcher_win.h

index 644b2a55bb885fb442d0e400131a55c96e2bf371..6d8b44caec28183db49f2f79c7453dc43e15a553 100644

--- a/components/browser_watcher/exit_code_watcher_win.h

+++ b/components/browser_watcher/exit_code_watcher_win.h

@@ -17,7 +17,7 @@ namespace browser_watcher {

class ExitCodeWatcher {

public:

// Initialize the watcher with a registry path.

- explicit ExitCodeWatcher(const base::char16* registry_path);

+ explicit ExitCodeWatcher(const base::string16& registry_path);

~ExitCodeWatcher();

// Initializes from arguments on |cmd_line|, returns true on success.

@@ -40,7 +40,7 @@ class ExitCodeWatcher {

bool WriteProcessExitCode(int exit_code);

// The registry path the exit codes are written to.

- base::string16 registry_path_;

+ const base::string16 registry_path_;

// Watched process and its creation time.

base::Process process_;