chrome/chrome_watcher/chrome_watcher_main_api.h - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_watcher/chrome_watcher_main_api.h

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/chrome_watcher/chrome_watcher_main.cc ('K') | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | chrome/common/chrome_constants.h » ('j') | chrome/common/chrome_constants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_watcher/chrome_watcher_main_api.h

diff --git a/chrome/chrome_watcher/chrome_watcher_main_api.h b/chrome/chrome_watcher/chrome_watcher_main_api.h

index d2f129b4a93a4ffd6055b8138259f961459b417a..d7015273b665ec5ac03cf4c19331b2311c29d193 100644

--- a/chrome/chrome_watcher/chrome_watcher_main_api.h

+++ b/chrome/chrome_watcher/chrome_watcher_main_api.h

@@ -29,7 +29,7 @@ extern const base::FilePath::CharType kPermanentlyFailedReportsSubdir[];

// |channel_name| is the current Chrome distribution channel (one of

// installer::kChromeChannelXXX).

typedef int (*ChromeWatcherMainFunction)(

- const base::char16* registry_path,

+ const base::string16& registry_path,

HANDLE parent_process,

DWORD main_thread_id,

HANDLE on_initialized_event,

« chrome/chrome_watcher/chrome_watcher_main.cc ('K') | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | chrome/common/chrome_constants.h » ('j') | chrome/common/chrome_constants.h » ('J')