Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: chrome/common/BUILD.gn

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter
Patch Set: de-dup is_win blocks in GN too Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | chrome/common/chrome_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//chrome/common/features.gni") 6 import("//chrome/common/features.gni")
7 import("//chrome/version.gni") 7 import("//chrome/version.gni")
8 import("//mojo/public/tools/bindings/mojom.gni") 8 import("//mojo/public/tools/bindings/mojom.gni")
9 import("//tools/grit/grit_rule.gni") 9 import("//tools/grit/grit_rule.gni")
10 10
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 # targets independent of Chrome that we want to keep small. So we don't 344 # targets independent of Chrome that we want to keep small. So we don't
345 # want something large like //ui/base. 345 # want something large like //ui/base.
346 # 346 #
347 # Android doesn't have this structure and corresponding size limitation 347 # Android doesn't have this structure and corresponding size limitation
348 # on this target. On that platform one of the Chrome paths forwards to one 348 # on this target. On that platform one of the Chrome paths forwards to one
349 # implemented in //ui/base, so we need that dependency. 349 # implemented in //ui/base, so we need that dependency.
350 deps += [ "//ui/base" ] 350 deps += [ "//ui/base" ]
351 } 351 }
352 } 352 }
353 353
354 if (is_win) {
355 # GYP version: chrome/chrome_common.gypi:metrics_constants_util_win
356 source_set("metrics_constants_util_win") {
357 sources = [
358 "metrics_constants_util_win.cc",
359 "metrics_constants_util_win.h",
360 ]
361
362 deps = [
363 "//base",
364 "//chrome/installer/util:with_no_strings",
365 ]
366 }
367 }
368
354 source_set("test_support") { 369 source_set("test_support") {
355 testonly = true 370 testonly = true
356 visibility = [ "//chrome/test:test_support" ] 371 visibility = [ "//chrome/test:test_support" ]
357 372
358 sources = [] 373 sources = []
359 374
360 deps = [ 375 deps = [
361 ":common", 376 ":common",
362 "//base", 377 "//base",
363 "//testing/gtest", 378 "//testing/gtest",
(...skipping 11 matching lines...) Expand all
375 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 390 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
376 391
377 if (enable_extensions) { 392 if (enable_extensions) {
378 sources += [ 393 sources += [
379 "extensions/extension_test_util.cc", 394 "extensions/extension_test_util.cc",
380 "extensions/extension_test_util.h", 395 "extensions/extension_test_util.h",
381 ] 396 ]
382 } 397 }
383 } 398 }
384 399
385 # GN version: chrome/chrome.gyp:app_mode_app_support 400 # GYP version: chrome/chrome.gyp:app_mode_app_support
386 source_set("app_mode_app_support") { 401 source_set("app_mode_app_support") {
387 sources = [ 402 sources = [
388 "mac/app_mode_chrome_locator.h", 403 "mac/app_mode_chrome_locator.h",
389 "mac/app_mode_chrome_locator.mm", 404 "mac/app_mode_chrome_locator.mm",
390 "mac/app_mode_common.h", 405 "mac/app_mode_common.h",
391 "mac/app_mode_common.mm", 406 "mac/app_mode_common.mm",
392 ] 407 ]
393 408
394 deps = [ 409 deps = [
395 ":constants", 410 ":constants",
396 "//base", 411 "//base",
397 ] 412 ]
398 } 413 }
399 414
400 mojom("mojo_bindings") { 415 mojom("mojo_bindings") {
401 sources = [ 416 sources = [
402 "image_decoder.mojom", 417 "image_decoder.mojom",
403 "resource_usage_reporter.mojom", 418 "resource_usage_reporter.mojom",
404 ] 419 ]
405 420
406 public_deps = [ 421 public_deps = [
407 "//skia/public/interfaces", 422 "//skia/public/interfaces",
408 ] 423 ]
409 } 424 }
OLDNEW
« no previous file with comments | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | chrome/common/chrome_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698