Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

chrome/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//chrome/common/features.gni")
 import("//chrome/version.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 import("//tools/grit/grit_rule.gni")
 
@@ skipping 333 matching lines @@
     # targets independent of Chrome that we want to keep small. So we don't
     # want something large like //ui/base.
     #
     # Android doesn't have this structure and corresponding size limitation
     # on this target. On that platform one of the Chrome paths forwards to one
     # implemented in //ui/base, so we need that dependency.
     deps += [ "//ui/base" ]
   }
 }
 
+# GYP version: chrome/chrome_common.gypi:metrics_constants_util_win

[grt (UTC plus 2), 2016/04/15 15:29:32]

how about defining this in an is_win block?

[gab, 2016/04/15 18:14:07]

Done. The dependency for chrome_initial target was already in an is_win block,
the chrome_watcher one isn't but the whole target is win-only (it just isn't
explicit, nor is it in GYP, and I'm not going to address that), the new
'browser' dependency wasn't but I moved it to the is_win block too.

+source_set("metrics_constants_util_win") {
+  sources = [
+    "metrics_constants_util_win.cc",
+    "metrics_constants_util_win.h",
+  ]
+
+  deps = [
+    "//base",
+    "//chrome/installer/util:with_no_strings",
+  ]
+}
+
 source_set("test_support") {
   testonly = true
   visibility = [ "//chrome/test:test_support" ]
 
   sources = []
 
   deps = [
     ":common",
     "//base",
     "//testing/gtest",
@@ skipping 11 matching lines @@
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   if (enable_extensions) {
     sources += [
       "extensions/extension_test_util.cc",
       "extensions/extension_test_util.h",
     ]
   }
 }
 
-# GN version: chrome/chrome.gyp:app_mode_app_support
+# GYP version: chrome/chrome.gyp:app_mode_app_support
 source_set("app_mode_app_support") {
   sources = [
     "mac/app_mode_chrome_locator.h",
     "mac/app_mode_chrome_locator.mm",
     "mac/app_mode_common.h",
     "mac/app_mode_common.mm",
   ]
 
   deps = [
     ":constants",
     "//base",
   ]
 }
 
 mojom("mojo_bindings") {
   sources = [
     "image_decoder.mojom",
     "resource_usage_reporter.mojom",
   ]
 
   public_deps = [
     "//skia/public/interfaces",
   ]
 }