Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: chrome/chrome_common.gypi

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter
Patch Set: nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # File lists shared with GN build. 7 # File lists shared with GN build.
8 'chrome_common_sources': [ 8 'chrome_common_sources': [
9 'common/all_messages.h', 9 'common/all_messages.h',
10 'common/attrition_experiments.h', 10 'common/attrition_experiments.h',
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 ], 649 ],
650 'sources': [ 650 'sources': [
651 'common/image_decoder.mojom', 651 'common/image_decoder.mojom',
652 'common/resource_usage_reporter.mojom', 652 'common/resource_usage_reporter.mojom',
653 ], 653 ],
654 'dependencies': [ 654 'dependencies': [
655 '../mojo/mojo_public.gyp:mojo_cpp_bindings', 655 '../mojo/mojo_public.gyp:mojo_cpp_bindings',
656 '../skia/skia.gyp:skia_mojo', 656 '../skia/skia.gyp:skia_mojo',
657 ], 657 ],
658 }, 658 },
659 {
660 # GN version: //chrome/common:metrics_constants_util_win
grt (UTC plus 2) 2016/04/15 15:29:32 i think it's entirely appropriate to put this in a
gab 2016/04/15 18:14:06 Didn't initially think that was the right way but
661 'target_name': 'metrics_constants_util_win',
662 'type': 'static_library',
663 'sources': [
664 'common/metrics_constants_util_win.cc',
665 'common/metrics_constants_util_win.h',
666 ],
667 'dependencies': [
668 'installer_util',
669 '../base/base.gyp:base',
670 ],
671 },
659 ], 672 ],
660 } 673 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698