chrome/common/chrome_constants_util_win.h - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/chrome_constants_util_win.h

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: rebase on r373339 and rm unused install_util.h include Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // A handful of resource-like constants related to the Chrome application.

	6

	7 #ifndef CHROME_COMMON_CHROME_CONSTANTS_UTIL_WIN_H_

	8 #define CHROME_COMMON_CHROME_CONSTANTS_UTIL_WIN_H_

	9

	10 #include "base/strings/string16.h"

	11

	12 // Returns the registry path where crash dump attempts are stored for this

	13 // product. This is used by breakpad and the metrics reporting.
	grt (UTC plus 2) 2016/02/04 15:52:30 isn't breakpad dead? should this say crashpad (or isn't breakpad dead? should this say crashpad (or something else that doesn't explicitly name the crash handler)? gab 2016/03/07 21:53:55 It's used in chrome/app/chrome_crash_reporter_clie Show quoted text On 2016/02/04 15:52:30, grt wrote: > isn't breakpad dead? should this say crashpad (or something else that doesn't > explicitly name the crash handler)? It's used in chrome/app/chrome_crash_reporter_client.cc, made the comment generic.
	14 base::string16 GetBrowserCrashDumpAttemptsRegistryPath();

	15

	16 // Returns the registry path where exit code are stored for this product. This

	17 // is used by browser exit code metrics reporting.

	18 base::string16 GetBrowserExitCodesRegistryPath();

	19

	20 #endif // CHROME_COMMON_CHROME_CONSTANTS_UTIL_WIN_H_

OLD	NEW

« no previous file with comments | « chrome/common/chrome_constants.cc ('k') | chrome/common/chrome_constants_util_win.cc » ('j') | chrome/common/chrome_constants_util_win.cc » ('J')