Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

chrome/common/chrome_constants_util_win.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/chrome_constants_util_win.h"
+
+#include "chrome/installer/util/browser_distribution.h"

[grt (UTC plus 2), 2016/02/04 15:52:30]

common_constants doesn't depend on installer_util, so this shouldn't be allowed.
for some reason chrome_paths_win.cc has been doing this all along, but it's
wrong. either common_constants needs to depend on installer_util, or this
functionality needs to be in common (not common_constants), which does depend on
installer_util.

[gab, 2016/03/07 21:53:55]

Good catch, I think it's reasonable to add the dependency since chrome_common
has it already.

I made it "win" only even though the installer_util target itself isn't, WDYT?

[grt (UTC plus 2), 2016/03/08 15:44:47]

I'm concerned about making a "constants" target pull in installer_util since it
adds weight to something that sounds like it should be very light. Is there
another way?

[gab, 2016/03/09 20:29:35]

Fair enough. Thought of naming these chrome_paths_win.cc/h (;-)) then and
putting them in chrome's "common" target proper.

But that only supports 2/4 places that need these methods as chrome/app doesn't
depend on "common"...

Actually AFAICT there is no official dependency to even "common_constants" in
chrome/app (nothing in chrome_exe.gypi at least..)?!

[grt (UTC plus 2), 2016/03/10 19:14:42]

Huh. Here's what is currently used by chrome.exe from common_constants.lib at
link time:

chrome::kBrowserExitCodesRegistryPath
- MainDllLoader::Launch (for watcher)
chrome::GetDefaultUserDataDirectory(class base::FilePath *)
- AttemptFastNotify
icon_resources::kApplicationIndex
- GoogleChromeDistribution::GetIconIndex
- BrowserDistribution::GetIconIndex
env_vars::kHeadless
- ChromeCrashReporterClient::IsRunningUnattended
switches::kProfileDirectory
- IsFastStartSwitch
chrome::RegisterPathProvider()
- MainDllLoader::Launch (for watcher)

The two from installer_util already depend on common_constants. Sure looks like
the chrome_initial target is missing a win-only dependency on common_constants,
and is only getting it transitively via installer_util.

+
+namespace {
+
+base::string16 GetSuffixedRegistryPath(const wchar_t* suffix) {
+  BrowserDistribution* chrome_distribution =

[grt (UTC plus 2), 2016/02/04 15:52:30]

  DCHECK_EQ(L'\\', *suffix);

[gab, 2016/03/07 21:53:55]

Done.

+      BrowserDistribution::GetDistribution();
+  DCHECK(chrome_distribution);
+  DCHECK_EQ(BrowserDistribution::CHROME_BROWSER,
+            chrome_distribution->GetType());
+  return chrome_distribution->GetRegistryPath() + suffix;

[grt (UTC plus 2), 2016/02/04 15:52:30]

  DCHECK_NE(L'\\', the last char of GetRegistryPath());

[gab, 2016/03/07 21:53:55]

Done.

+}
+
+}  // namespace
+
+base::string16 GetBrowserCrashDumpAttemptsRegistryPath() {
+  return GetSuffixedRegistryPath(L"\\BrowserCrashDumpAttempts");
+}
+
+base::string16 GetBrowserExitCodesRegistryPath() {
+  return GetSuffixedRegistryPath(L"\\BrowserExitCodes");
+}