Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

components/browser_watcher/watcher_metrics_provider_win.h

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_
 #define COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "base/task_runner.h"
 #include "components/metrics/metrics_provider.h"
 
 namespace browser_watcher {
 
 // Provides stability data captured by the Chrome Watcher, namely the browser
 // process exit codes.
 class WatcherMetricsProviderWin : public metrics::MetricsProvider {
  public:
   static const char kBrowserExitCodeHistogramName[];
 
   // Initializes the reporter. |cleanup_io_task_runner| is used to clear
   // leftover data in registry if metrics reporting is disabled.
-  WatcherMetricsProviderWin(const base::char16* registry_path,
+  WatcherMetricsProviderWin(const base::string16& registry_path,

[Sigurður Ásgeirsson, 2016/01/25 20:50:24]

this'll force an extra copy. No biggie except we force these all over, and in
aggregate they're likely killing us. How about a StringPiece?

[gab, 2016/01/26 02:55:05]

I don't think it does as the char* were replaced by const string& and both
result in a copy when reaching the base::string16 member of the class.

(see suggestion in other comment though to perhaps even avoid that copy)

[grt (UTC plus 2), 2016/01/26 16:13:04]

I like the StringPiece suggestion since it doesn't require that the caller
create a base::string16. As far as I can tell, StringPiece is currently a POD
type. I'm not sure if this is guaranteed in the future, though, since the
comments don't seem to say "This is and will always be a POD type."

                             base::TaskRunner* cleanup_io_task_runner);
   ~WatcherMetricsProviderWin() override;
 
   // metrics::MetricsProvider implementation.
   void OnRecordingEnabled() override;
   void OnRecordingDisabled() override;
   void ProvideStabilityMetrics(
       metrics::SystemProfileProto* system_profile_proto) override;
 
  private:
   bool recording_enabled_;
   bool cleanup_scheduled_;
-  base::string16 registry_path_;
+  const base::string16 registry_path_;
   scoped_refptr<base::TaskRunner> cleanup_io_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(WatcherMetricsProviderWin);
 };
 
 }  // namespace browser_watcher
 
 #endif  // COMPONENTS_BROWSER_WATCHER_WATCHER_METRICS_PROVIDER_WIN_H_