Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version

Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version

This patch introduces |SelectionAdjuster| class to consolidate functions
adjusting DOM tree version and composed tree version of selections in
|VisibleSelection| class and |SelectionEditor| in one place to avoid having
six parameters constructor, and rude name function |createWithoutValidation()|
to simplify source code for improving readability.

Note: For ease of reviewing to compare changes, this patch doesn't leave
functions in original place. Following patch moves them to
"SelectionAdjust.{cpp,h}".

This patch is a preparation of introducing |m_hasTrailingWhitespace| into
|VisibleSelection| class, which makes six parameters constructor to seven
parameters constructor without this patch.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/647b2143c21fade656c085f5a83426e96acbd38a
Cr-Commit-Position: refs/heads/master@{#371697}

[yosin_UTC9, 2016-01-26 07:22:48]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 07:23:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1630903005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1630903005/1

[yosin_UTC9, 2016-01-26 07:29:47]

Description was changed from

==========
Introduce SelectionAdjuster to adjust selecitons between DOM tree version and
composed tree version

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Introduce SelectionAdjuster to adjust selections between DOM tree version and
composed tree version

This patch introduces |SelectionAdjuster| class to consolidate functions
adjusting DOM tree version and composed tree version of selections in
|VisibleSelection| class and |SelectionEditor| in one place to avoid having
six parameters constructor, and rude name function |createWithoutValidation()|
to simplify source code for improving readability.

Note: For ease of reviewing to compare changes, this patch doesn't leave
functions in original place. Following patch moves them to
"SelectionAdjust.{cpp,h}".

This patch is a preparation of introducing |m_hasTrailingWhitespace| into
|VisibleSelection| class, which makes six parameters constructor to seven
parameters constructor without this patch.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-01-26 07:29:47]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, tkent@chromium.org, xiaochengh@chromium.org,
yoichio@chromium.org

[yosin_UTC9, 2016-01-26 07:30:40]

PTAL

[commit-bot: I haz the power, 2016-01-26 08:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 08:03:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-01-26 09:28:22]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 09:28:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1630903005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1630903005/20001

[commit-bot: I haz the power, 2016-01-26 11:43:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 11:43:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yoichio, 2016-01-27 01:46:26]

lgtm

[yosin_UTC9, 2016-01-27 01:51:47]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-01-27 01:52:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1630903005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1630903005/20001

[commit-bot: I haz the power, 2016-01-27 03:07:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 03:09:47]

Description was changed from

==========
Introduce SelectionAdjuster to adjust selections between DOM tree version and
composed tree version

This patch introduces |SelectionAdjuster| class to consolidate functions
adjusting DOM tree version and composed tree version of selections in
|VisibleSelection| class and |SelectionEditor| in one place to avoid having
six parameters constructor, and rude name function |createWithoutValidation()|
to simplify source code for improving readability.

Note: For ease of reviewing to compare changes, this patch doesn't leave
functions in original place. Following patch moves them to
"SelectionAdjust.{cpp,h}".

This patch is a preparation of introducing |m_hasTrailingWhitespace| into
|VisibleSelection| class, which makes six parameters constructor to seven
parameters constructor without this patch.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Introduce SelectionAdjuster to adjust selections between DOM tree version and
composed tree version

This patch introduces |SelectionAdjuster| class to consolidate functions
adjusting DOM tree version and composed tree version of selections in
|VisibleSelection| class and |SelectionEditor| in one place to avoid having
six parameters constructor, and rude name function |createWithoutValidation()|
to simplify source code for improving readability.

Note: For ease of reviewing to compare changes, this patch doesn't leave
functions in original place. Following patch moves them to
"SelectionAdjust.{cpp,h}".

This patch is a preparation of introducing |m_hasTrailingWhitespace| into
|VisibleSelection| class, which makes six parameters constructor to seven
parameters constructor without this patch.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/647b2143c21fade656c085f5a83426e96acbd38a
Cr-Commit-Position: refs/heads/master@{#371697}
==========

[commit-bot: I haz the power, 2016-01-27 03:09:47]

Patchset 2 (id:??) landed as
https://crrev.com/647b2143c21fade656c085f5a83426e96acbd38a
Cr-Commit-Position: refs/heads/master@{#371697}

[lushnikov, 2016-01-27 19:51:16]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1642723002/ by lushnikov@chromium.org.

The reason for reverting is: This patch breaks text selection in DevTools
console. Please see http://crbug.com/581800 for details.

[lushnikov, 2016-01-27 20:31:05]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1645713002/ by lushnikov@chromium.org.

The reason for reverting is: This patch breaks text selection in DevTools
console. Please see http://crbug.com/581800 for details..