Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1630903004:
check for both __ARM_NEON__ and __ARM_NEON (Closed)
Descriptioncheck for both __ARM_NEON__ and __ARM_NEON
No public API changes.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1630903004
Committed: https://skia.googlesource.com/skia/+/05332d9c8aefe00c361c893410deca33f4438695
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Description was changed from ========== check for both __ARM_NEON__ and __ARM_NEON BUG=skia: ========== to ========== check for both __ARM_NEON__ and __ARM_NEON BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== check for both __ARM_NEON__ and __ARM_NEON BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== check for both __ARM_NEON__ and __ARM_NEON BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
lsalzman@mozilla.com changed reviewers: + reed@google.com
gcc 4.7 only defines __ARM_NEON__. Only in gcc 4.8 did __ARM_NEON start getting defined as per the ARM spec. We modified the config checks for Firefox as per this bug report here: https://bugzilla.mozilla.org/show_bug.cgi?id=1239702#c21 This was causing performance issues because neon support wasn't properly compiling in, but fixed with this patch.
mtklein@google.com changed reviewers: + mtklein@google.com
(lgtm)
The CQ bit was checked by lsalzman@mozilla.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630903004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
On 2016/01/26 15:15:38, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, > http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...) Says presubmit failed because it may have modified the public API? I guess it thinks that because a header file got changed? Although clearly this patch does not. What to do?
On 2016/01/26 15:29:08, lsalzman1 wrote: > On 2016/01/26 15:15:38, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, > > > http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...) > > Says presubmit failed because it may have modified the public API? I guess it > thinks that because a header file got changed? Although clearly this patch does > not. What to do? Keep reading. :) "If this CL only removes from or doesn't change Skia's public API, please add a short note to the CL saying so and add one of those reviewers on a TBR= line." Let's add this somewhere in your CL description: No public API changes. TBR=reed@google.com
Description was changed from ========== check for both __ARM_NEON__ and __ARM_NEON BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== check for both __ARM_NEON__ and __ARM_NEON No public API changes. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by lsalzman@mozilla.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630903004/1
Message was sent while issue was closed.
Description was changed from ========== check for both __ARM_NEON__ and __ARM_NEON No public API changes. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== check for both __ARM_NEON__ and __ARM_NEON No public API changes. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/05332d9c8aefe00c361c893410deca33f4438695 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/05332d9c8aefe00c361c893410deca33f4438695 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
