Remove not needed ExtensionUpdater::default_params_ and its setter.

Remove not needed ExtensionUpdater::default_params_ and its setter.

I was going to rename set_default_check_params() to
set_default_check_params_for_testing(), but then realized we don't
need this at all.
Then asargent@ pointed out that we don't even need the member
default_params_ in ExtensionUpdater.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.

Committed: https://crrev.com/8fca7c925095e31450795e601fe5495874fe2212
Cr-Commit-Position: refs/heads/master@{#371524}

[lazyboy, 2016-01-25 22:56:40]

Description was changed from

==========
Remove not needed ExtensionUpdater::set_default_check_params().

One use of this was to specify check_blacklist (http://crrev.com/11339047),
  however, later this was removed (http://crrev.com/23591050), but the
  code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

to

==========
Remove not needed ExtensionUpdater::set_default_check_params().

I was going to rename this to set_default_check_params_for_testing(),
but then realized we don't need this at all.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
  however, later this was removed (http://crrev.com/23591050), but the
  code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

[lazyboy, 2016-01-25 22:57:30]

Description was changed from

==========
Remove not needed ExtensionUpdater::set_default_check_params().

I was going to rename this to set_default_check_params_for_testing(),
but then realized we don't need this at all.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
  however, later this was removed (http://crrev.com/23591050), but the
  code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

to

==========
Remove not needed ExtensionUpdater::set_default_check_params().

I was going to rename this to set_default_check_params_for_testing(),
but then realized we don't need this at all.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

[lazyboy, 2016-01-25 22:57:43]

lazyboy@chromium.org changed reviewers:
+ asargent@chromium.org

[asargent_no_longer_on_chrome, 2016-01-25 23:11:16]

great catch, lgtm with one suggestion

https://chromiumcodereview.appspot.com/1630903003/diff/1/chrome/browser/exten...
File chrome/browser/extensions/updater/extension_updater.h (left):

https://chromiumcodereview.appspot.com/1630903003/diff/1/chrome/browser/exten...
chrome/browser/extensions/updater/extension_updater.h:125: default_params_ =
params;
Can we also kill the default_params_ variable itself, and just pass a temporary
CheckParams() in the calls we make to CheckNow in extension_updater.cc? It
doesn't look like we hold any pointers/references to members of the CheckParams
passed into CheckNow beyond the lifetime of the call.

[lazyboy, 2016-01-25 23:46:38]

Description was changed from

==========
Remove not needed ExtensionUpdater::set_default_check_params().

I was going to rename this to set_default_check_params_for_testing(),
but then realized we don't need this at all.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

to

==========
Remove not needed ExtensionUpdater::default_params_ and its setter.

I was going to rename set_default_check_params() to
set_default_check_params_for_testing(), but then realized we don't
need this at all.
Then asargent@ pointed out that we don't even need the member
default_params_ in ExtensionUpdater.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

[lazyboy, 2016-01-25 23:46:58]

https://chromiumcodereview.appspot.com/1630903003/diff/1/chrome/browser/exten...
File chrome/browser/extensions/updater/extension_updater.h (left):

https://chromiumcodereview.appspot.com/1630903003/diff/1/chrome/browser/exten...
chrome/browser/extensions/updater/extension_updater.h:125: default_params_ =
params;
On 2016/01/25 23:11:16, Antony Sargent wrote:
> Can we also kill the default_params_ variable itself, and just pass a
temporary
> CheckParams() in the calls we make to CheckNow in extension_updater.cc? It
> doesn't look like we hold any pointers/references to members of the
CheckParams
> passed into CheckNow beyond the lifetime of the call. 
> 

Even better, thanks.
Done.

[lazyboy, 2016-01-26 16:20:36]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2016-01-26 16:20:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1630903003/#ps20001
(title: "removed ExtensionUpdater::default_params_")

[commit-bot: I haz the power, 2016-01-26 16:20:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1630903003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1630903003/20001

[commit-bot: I haz the power, 2016-01-26 16:58:47]

Description was changed from

==========
Remove not needed ExtensionUpdater::default_params_ and its setter.

I was going to rename set_default_check_params() to
set_default_check_params_for_testing(), but then realized we don't
need this at all.
Then asargent@ pointed out that we don't even need the member
default_params_ in ExtensionUpdater.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

to

==========
Remove not needed ExtensionUpdater::default_params_ and its setter.

I was going to rename set_default_check_params() to
set_default_check_params_for_testing(), but then realized we don't
need this at all.
Then asargent@ pointed out that we don't even need the member
default_params_ in ExtensionUpdater.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

[commit-bot: I haz the power, 2016-01-26 16:58:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 17:00:07]

Description was changed from

==========
Remove not needed ExtensionUpdater::default_params_ and its setter.

I was going to rename set_default_check_params() to
set_default_check_params_for_testing(), but then realized we don't
need this at all.
Then asargent@ pointed out that we don't even need the member
default_params_ in ExtensionUpdater.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.
==========

to

==========
Remove not needed ExtensionUpdater::default_params_ and its setter.

I was going to rename set_default_check_params() to
set_default_check_params_for_testing(), but then realized we don't
need this at all.
Then asargent@ pointed out that we don't even need the member
default_params_ in ExtensionUpdater.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.

Committed: https://crrev.com/8fca7c925095e31450795e601fe5495874fe2212
Cr-Commit-Position: refs/heads/master@{#371524}
==========

[commit-bot: I haz the power, 2016-01-26 17:00:07]

Patchset 2 (id:??) landed as
https://crrev.com/8fca7c925095e31450795e601fe5495874fe2212
Cr-Commit-Position: refs/heads/master@{#371524}