Chromium Code Reviews| Index: chrome/browser/resources/md_user_manager/user_manager.js |
| diff --git a/chrome/browser/resources/user_manager/user_manager.js b/chrome/browser/resources/md_user_manager/user_manager.js |
| similarity index 67% |
| copy from chrome/browser/resources/user_manager/user_manager.js |
| copy to chrome/browser/resources/md_user_manager/user_manager.js |
| index 39d76d4764abe302a71089b17d7563c0322f5290..9bb3defc97cdf510fc45578a1bdc568cdd81e274 100644 |
| --- a/chrome/browser/resources/user_manager/user_manager.js |
| +++ b/chrome/browser/resources/md_user_manager/user_manager.js |
| @@ -1,28 +1,27 @@ |
| -// Copyright 2013 The Chromium Authors. All rights reserved. |
| -// Use of this source code is governed by a BSD-style license that can be |
| -// found in the LICENSE file. |
| +/* Copyright 2016 The Chromium Authors. All rights reserved. |
| + * Use of this source code is governed by a BSD-style license that can be |
| + * found in the LICENSE file. |
| + */ |
| + |
| <include src="../../../../ui/login/screen.js"> |
| <include src="../../../../ui/login/bubble.js"> |
| <include src="../../../../ui/login/login_ui_tools.js"> |
| <include src="../../../../ui/login/display_manager.js"> |
| -<include src="control_bar.js"> |
| <include src="../../../../ui/login/account_picker/screen_account_picker.js"> |
| <include src="../../../../ui/login/account_picker/user_pod_row.js"> |
| <include src="../../../../ui/login/resource_loader.js"> |
| -<include src="user_manager_tutorial.js"> |
| + |
| cr.define('cr.ui', function() { |
| var DisplayManager = cr.ui.login.DisplayManager; |
| - var UserManagerTutorial = cr.ui.login.UserManagerTutorial; |
| /** |
| - * Constructs an Out of box controller. It manages initialization of screens, |
| - * transitions, error messages display. |
| - * @extends {DisplayManager} |
| - * @constructor |
| + * Constructs an Out of box controller. It manages initialization of screens, |
| + * transitions, error messages display. |
| + * @constructor |
| + * @extends {DisplayManager} |
| */ |
| - function Oobe() { |
| - } |
| + function Oobe() {} |
| cr.addSingletonGetter(Oobe); |
| @@ -32,20 +31,17 @@ cr.define('cr.ui', function() { |
| /** |
| * Shows the given screen. |
| - * @param {bool} showGuest Whether the 'Browse as Guest' button is displayed. |
| - * @param {bool} showAddPerson Whether the 'Add Person' button is displayed. |
| + * @param {boolean} showGuest True if |Browse as Guest| button should be |
| + * displayed. |
| + * @param {boolean} showAddPerson True if |Add Person| button should be |
| + * displayed. |
| */ |
| Oobe.showUserManagerScreen = function(showGuest, showAddPerson) { |
| Oobe.getInstance().showScreen({id: 'account-picker', |
| data: {disableAddUser: false}}); |
| - // The ChromeOS account-picker will hide the AddUser button if a user is |
| - // logged in and the screen is "locked", so we must re-enabled it |
| - $('add-user-header-bar-item').hidden = false; |
| - |
| // Hide control options if the user does not have the right permissions. |
| - $('guest-user-button').hidden = !showGuest; |
| - $('add-user-button').hidden = !showAddPerson; |
| - $('login-header-bar').hidden = false; |
| + document.querySelector('control-bar').showGuest = showGuest; |
| + document.querySelector('control-bar').showAddPerson = showAddPerson; |
| // Disable the context menu, as the Print/Inspect element items don't |
| // make sense when displayed as a widget. |
| @@ -53,12 +49,12 @@ cr.define('cr.ui', function() { |
| var hash = window.location.hash; |
| if (hash && hash == '#tutorial') |
| - UserManagerTutorial.startTutorial(); |
| + document.querySelector('user-manager-tutorial').startTutorial(); |
| }; |
| /** |
| * Open a new browser for the given profile. |
| - * @param {string} profilePath The profile's path. |
| + * @param {string=} profilePath The profile's path. |
|
tommycli
2016/02/09 18:33:20
Why string=? is that a typo?
Dan Beam
2016/02/09 18:55:33
that means optional
this variable should be prefi
Moe
2016/02/10 22:28:09
Done.
Moe
2016/02/10 22:28:09
This parameter isn't optional after all. I removed
|
| */ |
| Oobe.launchUser = function(profilePath) { |
| chrome.send('launchUser', [profilePath]); |
| @@ -73,10 +69,10 @@ cr.define('cr.ui', function() { |
| /** |
| * Shows signin UI. |
| - * @param {string} opt_email An optional email for signin UI. |
| + * @param {string|undefined} optEmail An optional email for signin UI. |
| */ |
| - Oobe.showSigninUI = function(opt_email) { |
| - DisplayManager.showSigninUI(opt_email); |
| + Oobe.showSigninUI = function(optEmail) { |
| + DisplayManager.showSigninUI(optEmail); |
| }; |
| /** |
| @@ -113,11 +109,9 @@ cr.define('cr.ui', function() { |
| /** |
| * Show the user manager tutorial |
| - * @param {string} email The user's email, if signed in. |
| - * @param {string} displayName The user's display name. |
| */ |
| Oobe.showUserManagerTutorial = function() { |
| - UserManagerTutorial.startTutorial(); |
| + document.querySelector('user-manager-tutorial').startTutorial(); |
| }; |
| // Export |
| @@ -131,14 +125,8 @@ cr.define('UserManager', function() { |
| function initialize() { |
| cr.ui.login.DisplayManager.initialize(); |
| - cr.ui.login.UserManagerTutorial.initialize(); |
| login.AccountPickerScreen.register(); |
| cr.ui.Bubble.decorate($('bubble')); |
| - login.HeaderBar.decorate($('login-header-bar')); |
| - |
| - // Hide the header bar until the showUserManagerMethod can apply function |
| - // parameters that affect widget visiblity. |
| - $('login-header-bar').hidden = true; |
| chrome.send('userManagerInitialize', [window.location.hash]); |
| } |