Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Side by Side Diff: chrome/browser/resources/md_user_manager/create_profile.html

Issue 1630903002: material design user manager with create profile flow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed tommy's comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <link rel="import" href="chrome://md-user-manager/profile_api.html">
2 <link rel="import" href="chrome://resources/html/action_link.html">
3 <link rel="import" href="chrome://resources/html/cr.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
10 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">
11 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html">
12 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
13
14 <dom-module id="create-profile">
15 <link rel="stylesheet" type="css" href="create_profile.css">
16 <link rel="stylesheet" href="chrome://resources/css/roboto.css">
17 <template>
18 <div class="container">
19 <div id="title-bar" i18n-content="createProfileTitle"></div>
20 <paper-input id="nameInput" value="{{profileName}}" pattern=".*\S.*"
21 auto-validate>
22 </paper-input>
23 <div id="icons">
24 <div id="wrapper">
25 <template is="dom-repeat" items="[[availableIconUrls]]">
26 <paper-button toggles on-tap="onIconTap_" data-icon-url$="[[item]]"
27 active$="{{isActiveIcon_(item, profileIconUrl)}}">
tommycli 2016/02/08 18:45:18 I think in most of these cases where you use the '
Moe 2016/02/09 00:15:33 you're right. except for "hidden" the rest are pro
28 <img src="[[item]]">
29 </paper-button>
30 </template>
31 </div>
32 </div>
33 <div id="createSupervisedContainer">
34 <span hidden$="{{!signedIn_}}">
35 <paper-checkbox checked="{{isSupervised_}}"
36 disabled$="{{supervisedUserCheckboxDisabled_}}">
37 <span i18n-content="manageProfilesSupervisedSignedInLabel"></span>
38 </paper-checkbox>
39 <paper-dropdown-menu no-label-float>
40 <paper-menu selected="{{selectedEmail_}}" class="dropdown-content">
41 <template is="dom-repeat" items="[[signedInUsers_]]">
42 <paper-item>[[item.username]]</paper-item>
43 </template>
44 </paper-menu>
45 </paper-dropdown-menu>
46 <a id="learnMoreLink" is="action-link" i18n-content="learnMore"
47 on-tap="onLearnMore_"></a>
48 </span>
49 <span id="create-profile-supervised-not-signed-in"
50 i18n-values=".innerHTML:manageProfilesSupervisedNotSignedIn"
tommycli 2016/02/08 18:45:18 I think you can do i18n-content instead of innerHT
Moe 2016/02/09 00:15:33 it seems like i18n-content sets the text content o
51 hidden$="{{signedIn_}}">
52 </span>
53 </span>
54 <div id="messageBubble" hidden$="{{!errorMessage_}}"></div>
tommycli 2016/02/08 18:45:18 See the js page on comments on how to improve mess
Moe 2016/02/09 00:15:33 Done.
55 </div>
56 <div id="actions" class="layout horizontal end-justified">
57 <paper-spinner active$="[[createInProgress_]]"></paper-spinner>
58 <paper-button id="cancel-button" on-tap="onCancel_"
59 i18n-content="cancel">
60 </paper-button>
61 <paper-button id="ok-button" on-tap="onOk_"
62 i18n-content="createProfileConfirm"
63 disabled$="{{isOkDisabled_(createInProgress_, profileName, \
tommycli 2016/02/08 18:45:18 No line continuations. If it doesn't fit, it's oka
Moe 2016/02/09 00:15:33 Done.
64 errorMessage_)}}">
65 </paper-button>
66 </div>
67 </div>
68 </template>
69 <script src="chrome://md-user-manager/create_profile.js"></script>
70 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698