material design user manager with create profile flow

chrome/browser/resources/md_user_manager/user_manager.js

-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
+/* Copyright 2016 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */

[Dan Beam, 2016/02/12 23:42:24]

revert to single-line comments

[Moe, 2016/02/20 00:21:00]

Done.

+
 <include src="../../../../ui/login/screen.js">
 <include src="../../../../ui/login/bubble.js">
 <include src="../../../../ui/login/login_ui_tools.js">
 <include src="../../../../ui/login/display_manager.js">
-<include src="control_bar.js">
 <include src="../../../../ui/login/account_picker/screen_account_picker.js">
 <include src="../../../../ui/login/account_picker/user_pod_row.js">
 <include src="../../../../ui/login/resource_loader.js">
-<include src="user_manager_tutorial.js">
+
 
 cr.define('cr.ui', function() {
   var DisplayManager = cr.ui.login.DisplayManager;
-  var UserManagerTutorial = cr.ui.login.UserManagerTutorial;
 
   /**
-  * Constructs an Out of box controller. It manages initialization of screens,
-  * transitions, error messages display.
-  * @extends {DisplayManager}
-  * @constructor
+   * Constructs an Out of box controller. It manages initialization of screens,
+   * transitions, error messages display.
+   * @constructor
+   * @extends {DisplayManager}
   */
-  function Oobe() {
-  }
+  function Oobe() {}

[Dan Beam, 2016/02/12 23:42:24]

why is this file named user_manager.js but the class defined in it is named
Oobe?

[Moe, 2016/02/20 00:21:00]

It looks like "user manager" was originally implemented taking advantage of a
lot of cros resources. I have been trying to keep the changes to this file
minimal to avoid breaking things. There will be follow ups in future to
re-implement the user pods and this page and divert from the cros.

 
   cr.addSingletonGetter(Oobe);
 
   Oobe.prototype = {
     __proto__: DisplayManager.prototype,
   };
 
   /**
    * Shows the given screen.
-   * @param {bool} showGuest Whether the 'Browse as Guest' button is displayed.
-   * @param {bool} showAddPerson Whether the 'Add Person' button is displayed.
+   * @param {boolean} showGuest True if |Browse as Guest| button should be
+   * displayed.
+   * @param {boolean} showAddPerson True if |Add Person| button should be
+   * displayed.
    */
   Oobe.showUserManagerScreen = function(showGuest, showAddPerson) {
     Oobe.getInstance().showScreen({id: 'account-picker',
                                    data: {disableAddUser: false}});
-    // The ChromeOS account-picker will hide the AddUser button if a user is
-    // logged in and the screen is "locked", so we must re-enabled it
-    $('add-user-header-bar-item').hidden = false;
-
     // Hide control options if the user does not have the right permissions.
-    $('guest-user-button').hidden = !showGuest;
-    $('add-user-button').hidden = !showAddPerson;
-    $('login-header-bar').hidden = false;
+    document.querySelector('control-bar').showGuest = showGuest;
+    document.querySelector('control-bar').showAddPerson = showAddPerson;

[Dan Beam, 2016/02/12 23:42:24]

re-use the result of this querySelector

[Moe, 2016/02/20 00:21:00]

Done.

 
     // Disable the context menu, as the Print/Inspect element items don't
     // make sense when displayed as a widget.
     document.addEventListener('contextmenu', function(e) {e.preventDefault();});
 
     var hash = window.location.hash;
     if (hash && hash == '#tutorial')
-      UserManagerTutorial.startTutorial();
+      document.querySelector('user-manager-tutorial').startTutorial();
   };
 
   /**
    * Open a new browser for the given profile.
    * @param {string} profilePath The profile's path.
    */
   Oobe.launchUser = function(profilePath) {
     chrome.send('launchUser', [profilePath]);
   };
 
   /**
    * Disables signin UI.
    */
   Oobe.disableSigninUI = function() {
     DisplayManager.disableSigninUI();
   };
 
   /**
    * Shows signin UI.
-   * @param {string} opt_email An optional email for signin UI.

[Dan Beam, 2016/02/12 23:42:24]

this was correct

[Moe, 2016/02/20 00:21:00]

Done.

+   * @param {string=} optEmail An optional email for signin UI.

[Dan Beam, 2016/02/12 23:42:24]

opt_paramsLikeThis

[Moe, 2016/02/20 00:21:00]

Done.

    */
-  Oobe.showSigninUI = function(opt_email) {
-    DisplayManager.showSigninUI(opt_email);
+  Oobe.showSigninUI = function(optEmail) {
+    DisplayManager.showSigninUI(optEmail);
   };
 
   /**
    * Shows sign-in error bubble.
-   * @param {number} loginAttempts Number of login attemps tried.
+   * @param {number} loginAttempts Number of login attempts tried.
    * @param {string} message Error message to show.
    * @param {string} link Text to use for help link.
    * @param {number} helpId Help topic Id associated with help link.
    */
   Oobe.showSignInError = function(loginAttempts, message, link, helpId) {
     DisplayManager.showSignInError(loginAttempts, message, link, helpId);
   };
 
   /**
    * Clears error bubble as well as optional menus that could be open.
@@ skipping 11 matching lines @@
 
   /**
    * Restores input focus to currently selected pod.
    */
   Oobe.refocusCurrentPod = function() {
     DisplayManager.refocusCurrentPod();
   };
 
   /**
    * Show the user manager tutorial
-   * @param {string} email The user's email, if signed in.
-   * @param {string} displayName The user's display name.
    */
   Oobe.showUserManagerTutorial = function() {
-    UserManagerTutorial.startTutorial();
+    document.querySelector('user-manager-tutorial').startTutorial();
   };
 
   // Export
   return {
     Oobe: Oobe
   };
 });
 
 cr.define('UserManager', function() {
   'use strict';
 
   function initialize() {
     cr.ui.login.DisplayManager.initialize();
-    cr.ui.login.UserManagerTutorial.initialize();
     login.AccountPickerScreen.register();
     cr.ui.Bubble.decorate($('bubble'));
-    login.HeaderBar.decorate($('login-header-bar'));
-
-    // Hide the header bar until the showUserManagerMethod can apply function
-    // parameters that affect widget visiblity.
-    $('login-header-bar').hidden = true;
 
     chrome.send('userManagerInitialize', [window.location.hash]);
   }
 
   // Return an object with all of the exports.
   return {
     initialize: initialize
   };
 });
 
 var Oobe = cr.ui.Oobe;
 
 // Allow selection events on components with editable text (password field)
 // bug (http://code.google.com/p/chromium/issues/detail?id=125863)
 disableTextSelectAndDrag(function(e) {
   var src = e.target;
   return src instanceof HTMLTextAreaElement ||
          src instanceof HTMLInputElement &&
          /text|password|search/.test(src.type);
 });
 
 document.addEventListener('DOMContentLoaded', UserManager.initialize);