Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: sdk/lib/io/process.dart

Issue 16309014: Add support for binary stdout/stderr data when using Process.run (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed debug print Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/process.dart
diff --git a/sdk/lib/io/process.dart b/sdk/lib/io/process.dart
index 808bce517dadd9e568c6d09a7d5bb20fb647c359..9ff803d06250952258f1eec777bf21067323099c 100644
--- a/sdk/lib/io/process.dart
+++ b/sdk/lib/io/process.dart
@@ -200,14 +200,20 @@ abstract class ProcessResult {
int get exitCode;
/**
- * Standard output from the process as a string.
+ * Standard output from the process. The value used for the
+ * `stdoutEncoding` argument to `Process.run` determins the type. If
+ * `Encoding.BINARY` was used this value is of type `List<int>
+ * otherwise it is of type `String`.
*/
- String get stdout;
+ get stdout;
/**
- * Standard error from the process as a string.
+ * Standard error from the process. The value used for the
+ * `stderrEncoding` argument to `Process.run` determins the type. If
+ * `Encoding.BINARY` was used this value is of type `List<int>
+ * otherwise it is of type `String`.
*/
- String get stderr;
+ get stderr;
/**
* Process id from the process.

Powered by Google App Engine
This is Rietveld 408576698