Fix a crash about editing an nonexistent bookmark

Fix a crash about editing an nonexistent bookmark

There can be race cases where a deleted bookmark is opened in edit
activity. This CL prevents such crashes from happening.

This CL also shortens an unnecessarily long variable name.

BUG=574680
Committed: https://crrev.com/daaa2439b468a72a7b956d83503996442e5654a9
Cr-Commit-Position: refs/heads/master@{#371327}

[Ian Wen, 2016-01-25 19:43:59]

ianwen@chromium.org changed reviewers:
+ kkimlabs@chromium.org

[Kibeom Kim (inactive), 2016-01-25 21:05:29]

lgtm with comment

https://codereview.chromium.org/1630893002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java
(right):

https://codereview.chromium.org/1630893002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java:119:
mModel.destroy();
do we need this destroy()? shouldn't this be called in onDestroy() below?

[Ian Wen, 2016-01-25 21:11:35]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-01-25 21:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkimlabs@chromium.org
Link to the patchset: https://codereview.chromium.org/1630893002/#ps40001
(title: "respond to comments")

[Ian Wen, 2016-01-25 21:11:39]

https://codereview.chromium.org/1630893002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java
(right):

https://codereview.chromium.org/1630893002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java:119:
mModel.destroy();
On 2016/01/25 21:05:29, Kibeom Kim wrote:
> do we need this destroy()? shouldn't this be called in onDestroy() below?

Oh yeah you are right. Done.

[commit-bot: I haz the power, 2016-01-25 21:12:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1630893002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1630893002/40001

[commit-bot: I haz the power, 2016-01-25 21:58:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-25 22:02:24]

Description was changed from

==========
Fix a crash about editing an nonexistent bookmark

There can be race cases where a deleted bookmark is opened in edit
activity. This CL prevents such crashes from happening.

This CL also shortens an unnecessarily long variable name.

BUG=574680
==========

to

==========
Fix a crash about editing an nonexistent bookmark

There can be race cases where a deleted bookmark is opened in edit
activity. This CL prevents such crashes from happening.

This CL also shortens an unnecessarily long variable name.

BUG=574680

Committed: https://crrev.com/daaa2439b468a72a7b956d83503996442e5654a9
Cr-Commit-Position: refs/heads/master@{#371327}
==========

[commit-bot: I haz the power, 2016-01-25 22:02:25]

Patchset 3 (id:??) landed as
https://crrev.com/daaa2439b468a72a7b956d83503996442e5654a9
Cr-Commit-Position: refs/heads/master@{#371327}