Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1630873003: Remove code for losing activation when child window activated. (Closed)

Created:
4 years, 11 months ago by jbauman
Modified:
4 years, 11 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code for losing activation when child window activated. This was intended only for use with NPAPI (now dead), and causes issues by thinking it can activate the DirectComposition child window. BUG=580938 Committed: https://crrev.com/1fd5e4108027eba514c0f7754e99f6240d6007a3 Cr-Commit-Position: refs/heads/master@{#371960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jbauman
The comment seems to indicate that this code isn't useful anymore.
4 years, 11 months ago (2016-01-26 01:03:28 UTC) #2
ananta
Please test whether clicking on the page, works correctly, i.e. the main window should not ...
4 years, 11 months ago (2016-01-26 23:14:59 UTC) #3
jbauman
On 2016/01/26 23:14:59, ananta wrote: > Please test whether clicking on the page, works correctly, ...
4 years, 11 months ago (2016-01-27 22:35:02 UTC) #4
ananta
lgtm
4 years, 11 months ago (2016-01-27 22:48:03 UTC) #5
jbauman
sky@: ui/views OWNERS review.
4 years, 11 months ago (2016-01-27 22:50:53 UTC) #7
sky
LGTM
4 years, 11 months ago (2016-01-28 00:53:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630873003/1
4 years, 11 months ago (2016-01-28 00:54:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 02:00:05 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:05:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd5e4108027eba514c0f7754e99f6240d6007a3
Cr-Commit-Position: refs/heads/master@{#371960}

Powered by Google App Engine
This is Rietveld 408576698