Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1630833002: Add UseBackground. (Closed)

Created:
4 years, 11 months ago by iannucci
Modified:
4 years, 11 months ago
Reviewers:
dnj, Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make BackgroundContext only available on managed VMs, document #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A impl/prod/context_vm.go View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
iannucci
4 years, 11 months ago (2016-01-25 18:47:07 UTC) #1
martiniss
lgtm
4 years, 11 months ago (2016-01-25 18:53:33 UTC) #2
Vadim Sh.
https://chromiumcodereview.appspot.com/1630833002/diff/1/impl/prod/context.go File impl/prod/context.go (right): https://chromiumcodereview.appspot.com/1630833002/diff/1/impl/prod/context.go#newcode90 impl/prod/context.go:90: // implementations which aren't associated with any particular request. ...
4 years, 11 months ago (2016-01-25 18:56:17 UTC) #3
iannucci
On 2016/01/25 at 18:56:17, vadimsh wrote: > https://chromiumcodereview.appspot.com/1630833002/diff/1/impl/prod/context.go > File impl/prod/context.go (right): > > https://chromiumcodereview.appspot.com/1630833002/diff/1/impl/prod/context.go#newcode90 ...
4 years, 11 months ago (2016-01-25 19:02:36 UTC) #4
Vadim Sh.
lgtm
4 years, 11 months ago (2016-01-25 19:08:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630833002/20001
4 years, 11 months ago (2016-01-25 19:08:39 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 19:09:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/ea770b89291efbda72378f5a313967aec98b6bd9

Powered by Google App Engine
This is Rietveld 408576698